Item Levels failing to apply to pets.

Hinekri commented 2 years ago

[x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
[x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated
[x] I have read and understood the Contributing Guide

Branch affected by issue

`petutils.cpp'

Steps to reproduce

I dunno where the code is supposed to be at to check it, (I thought it was already in, and thought it was petutils.cpp, but I didn't see it there just now) but this is THE ONLY place we set it. There is no modifier. There should not be one ever because that's not how its intended to work. Avatar still weak means it's probably missing a line of code to apply it to the avatar or that said line of code is broken.

^ Quote from my convo in Discussions related to the subject.

Use !getstats on an Avatar naked. Use !getstats on an Avatar with Epitaph iLvl119 Ammo. No changes in stats at all remains base lv99. Same results with Pup Automaton & Bst Jugs.

Expected behavior

Pets should scale with proper Item equipped Kirito_2022 05 29_141110 Kirito_2022 05 29_141119 .

TeoTwawki commented 2 years ago

related discussion: #1832

WinterSolstice8 commented 2 years ago

avatars, wyverns and automatons have various lvl+ modifier gear. trusts too, apparently. https://www.ffxiah.com/search/item?&description=Lv.%2B1#adv also all ilvl 119 Nirvanas have + levels for avatars as well

TeoTwawki commented 2 years ago

I'd really like us to stop using the word "modifier". we do not use a modifier and calling it that is going to have ppl confusing it with one. We have a column on the item in the database table. In the discussion thread I quoted BG's page for which slot affects the levels of which entities. Item level already exists on the item object itself. We just need to ensure it is checked and applied.

Me: HEY! I said its not a... SE: oh Teo... Me: ..no... NO! SE: :smiley: Me:

TeoTwawki commented 2 years ago

looks like I'm wrong about not needing a modifier, because SE didn't just use the same field for everyone:

Hinekri commented 2 years ago

avatars, wyverns and automatons have various lvl+ modifier gear. trusts too, apparently. https://www.ffxiah.com/search/item?&description=Lv.%2B1#adv also all ilvl 119 Nirvanas have + levels for avatars as well

Thats what I thought except theres no actual modifier to apply to gear to make them +level. All of that gear does nada currently.

Hinekri commented 2 years ago

looks like I'm wrong about not needing a modifier, because SE didn't just use the same field for everyone:

^^ Well atleast we know for certain it's broken and needs some modifier addition to make that gear work properly. Thanks for looking into it.

LandSandBoat / server