🐛 Audit mob_droplist table for unused or inaccurate entries - Githubissues

LandSandBoat / server

:sailboat: LandSandBoat - a server emulator for Final Fantasy XI

https://landsandboat.github.io/server/

GNU General Public License v3.0

298 stars 601 forks source link

🐛 Audit mob_droplist table for unused or inaccurate entries #2110

Open claywar opened 2 years ago

claywar commented 2 years ago

[x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
[x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated
[x] I have read and understood the Contributing Guide

Branch affected by issue

base There are 46 unused drop Ids that are currently populated in the mob_droplist table. Need to figure out what these are for and correct.

Steps to reproduce

Search mob_droplist for 'Unknown' after #2109 is merged

Expected behavior

There should be no Unknown entries

TeoTwawki commented 2 years ago

bear in mind scripts can change a mobs drop list - it could be that (some of) these IDs are alternated used by script after some condition is met

related: https://github.com/LandSandBoat/server/issues/975