🔨 Create Bonus vs Ecosystem handling

[Schaedelschaden]

• [x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
• [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated
• [x] I have read and understood the Contributing Guide

Describe the feature

https://www.bg-wiki.com/ffxi/Ancient_Circle (DRG) https://www.bg-wiki.com/ffxi/Arcane_Circle (DRK) https://www.bg-wiki.com/ffxi/Holy_Circle (PLD) https://www.bg-wiki.com/ffxi/Warding_Circle (SAM)

All of the above effects generate two additional bonuses beyond their original "Killer effect" bonus.

• Main job gives a unique 15% damage bonus against ECOSYSTEM.
• Main job gives a unique 15% damage resistance from ECOSYSTEM.

https://www.bg-wiki.com/ffxi/Killer_Instinct (BST/Pets)

Killer instinct states that:

While active on yourself and party members, will also provide a bonus to Damage+% and DamageTaken-% equal to half the total matching Killer Traits (floored) possessed by you or that party member. This bonus is separate from similar bonuses provided by equipment such as the Ferine/Nukumi Gausape variants and Founder's Breastplate, which augment killer effects. This means a party member benefitting from both Killer Instinct and a piece of gear which "Augments Killer Effects" like the Nukumi Gausape or Founder's Breastplate gain the full +% Killer Trait as a Damage+% and DamageTaken-% bonus.

This feature would require both core and LUA work to be applied across all white, weaponskill, and magical damage systems.

Referenced TODO PR's:

2789 (Holy Circle)

2847 (Holy Circle)

3138 (Arcane Circle)

[UmeboshiXI]

Bumping this as I was looking into how to implement this but am lacking some info if anyone is willing to help out.

Somethings I am having trouble finding concerning the calculations:

• Does the damage reduction bonus count towards any existing damage reduction caps?
• Does Killer Instinct count as a circle effect for the purposes of overwriting or being overwritten by other circle effects (Only 1 can be active normally between Holy, Warding, & Arcane).

[UmeboshiXI]

This seems to be at least partially implemented on Wings codebase on further inspection.

[Schaedelschaden]

My current understanding of it is that it is a unique damage bonus against an ecosystem and reduction to DT when taking taking damage from that ecosystem. This damage would not be part of the normal -50% cap. I believe, but cannot back up with testing, that DT is applied first then any further damage reduction bonuses are applied multiplicatively.

I can test Killer Instinct with a Circle effect on retail and see if they overwrite each other.