Zoned mobs are not resetting positions in vacated zones.

LandSandBoat / server

:sailboat: LandSandBoat - a server emulator for Final Fantasy XI

https://landsandboat.github.io/server/

GNU General Public License v3.0

289 stars 578 forks source link

Zoned mobs are not resetting positions in vacated zones. #349

Open Snugglesffxi opened 3 years ago

Snugglesffxi commented 3 years ago

[x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
[x] I have searched existing issues to see if the issue has already been opened
[x] I have checked the commit log to see if the issue has been resolved since my server was last updated
[x] I have read the Contributing Guide
[x] I have specified what branch this happens on branch: EDITME

Additional Information (Steps to reproduce/Expected behavior) :

An easy zone to reproduce is beadeaux/qulun dome aggro mobs > zone, wait > 5sec and rezone, they will still be there. even 15mins later they are still there.

I have a hunch this is causing some server instability as well. I just can't prove it yet as the crashes I've managed to produce are dead crashes with no logs. (It could just be my hairpin into my vbox, or that the vbox is bad, so I won't say for certain just yet.)

zach2good commented 3 years ago

Possibly caused by this: https://github.com/LandSandBoat/server/pull/284

Snugglesffxi commented 3 years ago

that was my thinking as well

zach2good commented 3 years ago

Theoretically, the same logic is being fired off, just 5 seconds later, I wonder what's getting missed 🤔

Snugglesffxi commented 3 years ago

honestly that's why I didn't even link it, it seems so innocent it doesn't seem like it could be... but it's the only thing that's been really changed that was related recently that I've noticed. 🤔

zach2good commented 3 years ago

Were mobs even correctly resetting when a zone shuts down before? I feel like this might be an old issue brought to light

Snugglesffxi commented 3 years ago

I'm pretty sure they were though I can't explicitly say or recall. We've only had the one report on SN and I had noticed it myself several days earlier. That said, how often does one really make a habit of zoning mobs... however someone would've noticed something sooner I'd say, esp in lower level zones.

Era-Lusiphur commented 3 years ago

I'm kind of interested in the comment regarding crashes. What are you using for logging? Notice any patterns or discuss it with players?

Snugglesffxi commented 3 years ago

FWIW - If you zone > 5sec w/gm status the mobs will "Run" to their positions.

Snugglesffxi commented 3 years ago

@Era-Lusiphur I don't run the live server just my own test box, the game client itself just dead crashes/hangs and produces no information.

Snugglesffxi commented 3 years ago

I caught the issue a few days ago on stream https://www.twitch.tv/videos/1060355561?t=07h47m25s it was a whole roller coaster. just use the arrow key to skip over the dead bits.

zach2good commented 3 years ago

I caught the issue a few days ago on stream https://www.twitch.tv/videos/1060355561?t=07h47m25s it was a whole roller coaster. just use the arrow key to skip over the dead bits.

This was actually very helpful! It looks like they make 5s of progress walking back to their spawn points, but then the zone goes to sleep