Somes zones are missing weather

[Era-Lusiphur]

• [x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
• [x] I have searched existing issues to see if the issue has already been opened
• [x] I have checked the commit log to see if the issue has been resolved since my server was last updated
• [x] I have read the Contributing Guide
• [x] I have specified what branch this happens on branch: Any

Additional Information (Steps to reproduce/Expected behavior) :

Numerous zones are missing weather information. For some of these zones, it results in a very vacant black sky that is very unappealing. A quick rundown of zones that are set to null/clear weather or are missing weather information is below.

Zone(s)	Notes/progress
abyssea zones	always clear
all prommy/prommy-attached zones
PVP zones
chocobo circuit
salvage zones
mordion goal	always clear
xarc/glacier/castle z (S)	fixed with #416
walk of echoes
legion
mog houses	sub zones: these aren't separate from where you entered. Port bastok mog IS port bastok
gm home	always clear
provenance
airship zones
unused 229 zone	fine being clear, unused
hall of the gods
all SoA field/dungeon zones
mog garden
escha zones

I will be submitting a PR to a few of these in Shadowreign areas shortly to fix them. Additional research may help decide if weather is needed in the remainder. It's possible the majority of these have no legitimate weather!

[Era-Lusiphur]

@KnowOne134 mentioned Salvage zones should have weather due to Gears mixin that increases aggro range during weather. He copied existing weather from another zone with the same weather to make it work.

After some quick research, it looks like the SoA field areas will also need some weather added.

[TeoTwawki]

:+1:

[KnowOne134]

Missed nyzul unless you count that in salvage zones, not sure if it has weather or not really

[Era-Lusiphur]

Missed nyzul unless you count that in salvage zones, not sure if it has weather or not really

Nyzul has some non-clear weather set. Though, to be fair, I'm not quite sure what weather pattern is set there at a glance after @Kreidos 's change up last year. It's the only zone with the pattern that it has.

EDIT: Checked the values before the conversion. It's 100% auroras (16).