🐛 Ranger Mobs: Missing Ranged Attack Animations

[UmeboshiXI]

I affirm:

• [x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
• [x] I have read and understood the Contributing Guide and the Code of Conduct.
• [x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Branch affected by issue

base

Steps to reproduce

Some mobs are missing ranged attack animations. I have been taking notes on which ones are missing as I go.

• Demons

• Trolls (I have this one working on my server as a port from Wings, see below.)

mobutils.cpp

else if (PMob->m_Family == 246) // Trolls { // Trolls love cannons, but they take a second to shoot PMob->defaultMobMod(MOBMOD_SPECIAL_SKILL, 1747); // so slow down the trolls a bit PMob->defaultMobMod(MOBMOD_STANDBACK_COOL, 4); }

mobskill.sql entry INSERT INTO mob_skills VALUES (1747,1236,'zarraqa',0,25.0,2000,0,4,4,0,0,0,0,0);

• Fomors: Specifically Fomor in Aquaducts/Sacrarium and Dynamis areas. Seems like they use different animations compared to say for example, the Spectres in Fei'yin?

Expected behavior

[TeoTwawki]

in addition to there being multiple different animations, there are even multiple types of ranged attack. Many mobs use a fake ranged attack that is actually a skill as you saw, but some will use an "actual" ranged attack. I might be wrong but I do not think we have any implementation of it at this time. As fomors are quite player-like, its possible they use that type. Demons and trolls I think have the skill type. Packet caps will need consulted in all cases.

p.s. Fomor and Shadow mobs typically use different models, so it makes sense the animation value is different between them.

[ShiyoKozuki]

in addition to there being multiple different animations, there are even multiple types of ranged attack. Many mobs use a fake ranged attack that is actually a skill as you saw, but some will use an "actual" ranged attack. I might be wrong but I do not think we have any implementation of it at this time. As fomors are quite player-like, its possible they use that type. Demons and trolls I think have the skill type. Packet caps will need consulted in all cases.

p.s. Fomor and Shadow mobs typically use different models, so it makes sense the animation value is different between them.

Tested on retail, fomors do not send a mob ability action packet for their RA