🐛 ToAU mission Raubahn Eyes on Me damage is... kinda sus

TeoTwawki commented 8 months ago

I affirm:

[x] I understand that if I do not agree to the following points by completing the checkboxes my issue will be ignored.
[x] I have read and understood the Contributing Guide and the Code of Conduct.
[x] I have searched existing issues to see if the issue has already been opened, and I have checked the commit log to see if the issue has been resolved since my server was last updated.

OS / platform the server is running (if known)

Windows Server 2019

Branch affected by issue

base

Steps to reproduce

Flag mission, Fight Raubahn, wait for cast, see this:

I'm told its not actually doing that damage, just says it is.

Expected behavior

Believable damage and accurately reflected in log.

TeoTwawki commented 8 months ago

possibly related to players not having a value for m_ecosystem (probably should actually, but only mobs have this right now)

Possible fix (untested!) :

-- Monster correlation
local correlationMultiplier = 0
if not target:isPC() then
    correlationMultiplier = calculateCorrelation(params.ecosystem, target:getEcosystem(), caster:getMerit(xi.merit.MONSTER_CORRELATION))
end

almuth150 commented 8 months ago

Does this affect other BLU magical spells? The server I play on has this issues for players casting such spells, but I assumed it was caught and fixed by now since it's been a little while since they've updated.

TeoTwawki commented 8 months ago

if a mob is the caster instead of a player, I would bet yes.

situation I am looking at is specifically a mob casting blue magic on a player. Not a player casting it. Any issues with player casting have nothing to do with this issue.

LandSandBoat / server