[x] I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.
What does this pull request do?
Roast Trout was throwing nil errors on Horizon on use and on effect wear off.
Upon further investigation - it was using the mods RATTP and RATT_CAP when it shoud be using FOOD_RATTP and FOOD_RATT_CAP.
RATT_CAP is not a defined mod, hence the nil error.
As a side effect - the RATT from this food was uncapped - making a great choice for mid 400 RATT.
Steps to test these changes
Be a 75 Ranger with capped marksmanship, and equip a Culverin.
use /checkparam <me> and note your Ranged Attack
!setmod RATT X where X will get you to 500 Ranged Attack or more (for easy math)
use /checkparam <me> and note your Ranged Attack of 500+
!additem roast_trout 12
eat a roast trout
use /checkparam <me> and note your Ranged Attack - the total gain should be 50 due to the cap
!deleffect food and note a reversion to step 4 values.
!setmod RATT 0 - this should bring your RATT to the low 300s - ensure it is below 358 as 358 will hit the cap.
eat a roast trout - note that you gain 14% ranged attack
I affirm:
What does this pull request do?
Roast Trout was throwing nil errors on Horizon on use and on effect wear off. Upon further investigation - it was using the mods
RATTPandRATT_CAPwhen it shoud be usingFOOD_RATTPandFOOD_RATT_CAP.RATT_CAPis not a defined mod, hence the nil error.As a side effect - the RATT from this food was uncapped - making a great choice for mid 400 RATT.
Steps to test these changes
/checkparam <me>and note your Ranged Attack!setmod RATT Xwhere X will get you to 500 Ranged Attack or more (for easy math)/checkparam <me>and note your Ranged Attack of 500+!additem roast_trout 12/checkparam <me>and note your Ranged Attack - the total gain should be50due to the cap!deleffect foodand note a reversion to step 4 values.!setmod RATT 0- this should bring your RATT to the low 300s - ensure it is below 358 as 358 will hit the cap.