LandSandBoat / server

:sailboat: LandSandBoat - a server emulator for Final Fantasy XI
https://landsandboat.github.io/server/
GNU General Public License v3.0
298 stars 599 forks source link

🐛 Sauromugue Champaign place's char under map #6253

Open Mortalelite opened 1 month ago

Mortalelite commented 1 month ago

I affirm:

OS / platform the server is running (if known)

Windows

Branch affected by issue

base

Steps to reproduce

Use GM Command !zone Sauromugue Champaign and will be placed under the map

Screenshot 2024-09-15 153933 Screenshot 2024-09-15 153643

Also the lua shows the same position https://github.com/LandSandBoat/server/blob/base/scripts/zones/Sauromugue_Champaign/Zone.lua#L25

Discord Post that Shizima made https://discord.com/channels/392903136336936960/832349765718900827/1284908588309151744

Expected behavior

Not be under the map when using !zone Sauromugue Champaign

EpicTaru commented 1 month ago

https://github.com/LandSandBoat/server/pull/3608 looks to be the commit that changed the default coordinates for a GM chara using !zone.

Checking the above PR and using the old coordinates places a GM chara at the zone out point from Garliage Citadel.

For reference, in the zonelines.sql file, the zone out point from Port Jeuno to Sauromugue Champaign is found at https://github.com/LandSandBoat/server/blob/1b174fb2ffc2820f30920cf6c5f0153605ee485e/sql/zonelines.sql#L176 (-574.647, -0.680, 399.974, 7), which the coordinates (-571, 1, 339, 7) in the lua linked in the issue ticket is not that far off from but is just far enough out of bounds to stick a character where it currently is.

-574.647, -0.680, 399.974, 7 -- old
-571    ,  1    , 339    , 7 -- existing

I'm wondering if the above PR meant to place a GM chara at the zone out point from Port Jeuno? It's an easy enough PR to fix the coordinates in the lua to be either one but which one should it be? Thoughts anyone?

DarkTannin commented 1 month ago

That's a good question. Sounds like there could be valid arguments for both. My vote would go to whichever would be the smallest change, hence the one near Garlaige since it's near what the current value is.