LandSandBoat / server

:sailboat: LandSandBoat - a server emulator for Final Fantasy XI
https://landsandboat.github.io/server/
GNU General Public License v3.0
301 stars 612 forks source link

[Quest] Implement Elderly Pursuits #6353

Closed slashtangent closed 1 month ago

slashtangent commented 1 month ago

I affirm:

What does this pull request do?

Adds the quest Elderly Pursuits, NM fight, and reward.

Steps to test these changes

Have Secrets of Ovens Lost Quest Completed Start the quest in Tav Stronghold by talking to Despachiaire !gotoid 16883721 -> Southern San d'Oria Talk to Rouva !gotoid 17719492 -> Carpenter's Landing Check QM to spawn Para NM Kill the ORIGINAL PARA Para will spawn clones when using specific tp moves when under 50% hp. Check QM again after original Para is dead -> Southern San d'Oria Talk to Rouva !gotoid 17719492 -> Tavnavian Safehold Talk to Despachiaire !gotoid 16883721 to end quest

Sources

Retail Captures: https://youtu.be/beJ9ca8aZYM https://1drv.ms/u/s!AlLEVQXhZeaHgWSuTwo2iHks5-P1?e=fwwJVs

Xaver-DaRed commented 1 month ago

As a rule of thumb, do not resolve conversations yourself. Those are for the original reviewer to resolve

zach2good commented 1 month ago

As a rule of thumb, do not resolve conversations yourself. Those are for the original reviewer to resolve

I was looking at this, and wondering if GitHub did it on the submitter's behalf when they pushed/force pushed? If GH hasn't taken control, please remember that we have this checkbox: I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.

^ It's to make life much easier for us while reviewing

(disregard if this is GH shenanigans)

zach2good commented 1 month ago

Everyone interacting with the PR gets an email every time you push a change. Every time you comment 'Done' we get an email. Please relax, we can see what's going on.

On Tue, Oct 15, 2024 at 10:38 PM slashtangent @.***> wrote:

@slashtangent https://github.com/slashtangent requested your review on:

6353 https://github.com/LandSandBoat/server/pull/6353 [Quest]

Implement Elderly Pursuits.

— Reply to this email directly, view it on GitHub https://github.com/LandSandBoat/server/pull/6353#event-14664886173, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKTJIOPPUO57FI2G2PRLKDZ3WDLZAVCNFSM6AAAAABP4JHD2WVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGY3DIOBYGYYTOMY . You are receiving this because your review was requested.Message ID: @.***>

slashtangent commented 1 month ago

Everyone interacting with the PR gets an email every time you push a change. Every time you comment 'Done' we get an email. Please relax, we can see what's going on.

Just needed some way to visibly see that a task was done. That's how my IRL workflow goes. I can just react to the comments moving forward when I'm done with them.

jamesbradleym commented 1 month ago

Feel free to take anything from here: https://github.com/LandSandBoat/server/pull/5191 like the mob mods for para or just returning the key item for the Obtained key item message 🤷‍♂️

Never got final approval but also didn't recieve additional comments on it