LandSandBoat / server

:sailboat: LandSandBoat - a server emulator for Final Fantasy XI
https://landsandboat.github.io/server/
GNU General Public License v3.0
301 stars 612 forks source link

[LUA]Move PUP JA to jobUtils file #6366

Closed hooksta4 closed 9 hours ago

hooksta4 commented 1 month ago

I affirm:

What does this pull request do?

Moves all PUP Job Abilities to job_utils lua. The only change I made was https://github.com/LandSandBoat/server/blob/base/scripts/actions/abilities/cooldown.lua#L12

Where I added the check for if not automaton.

Looking at ways to do some trimming for repetitive code like checking for automaton. However, each of the onAbilityCheck for pup seems to have an additional check so it may need to stay how it is.

image

xkoredev commented 1 month ago

LGTM

WinterSolstice8 commented 1 week ago

The CI failure isn't you, just need to rebase and you're good

hooksta4 commented 1 week ago

The CI failure isn't you, just need to rebase and you're good

Thanks - just was able to get some time to do it. Doing CI's now.