LandSandBoat / server

:sailboat: LandSandBoat - a server emulator for Final Fantasy XI
https://landsandboat.github.io/server/
GNU General Public License v3.0
301 stars 612 forks source link

[Lua] Simplified npc_util.lua logic, converted variable naming across files #6422

Closed Flibe-XI closed 1 week ago

Flibe-XI commented 2 weeks ago

I affirm:

What does this pull request do?

Tidy up variable naming convention for reward tables : 'ki' -> 'keyItem' & 'xp' -> 'exp' across many files, eliminating need for ambiguous variable handling in npc_utils.lua and roe.lua.

Steps to test these changes

Complete one of the affected quest, mission, or ROE, get appropriate rewards.