Shield Block rate formula is wrong. Round Shield block rate is wrong. Agi shouldn't work on block rate.

ShiyoKozuki commented 3 years ago

[x] I have paid attention to this example and will edit again if need be to not break the formatting, or I will be ignored
[x] I have searched existing issues to see if the issue has already been opened
[x] I have checked the commit log to see if the issue has been resolved since my server was last updated
[x] I have read the Contributing Guide
[x] I have specified what branch this happens on branch: EDITME

Additional Information (Steps to reproduce/Expected behavior) : https://www.bg-wiki.com/ffxi/Shield_block_rate Round Shields should be 40%, not 50%. https://github.com/LandSandBoat/server/blob/f909259cc9967f952cc7f90d1af5989bb61641bf/src/map/utils/battleutils.cpp#L1762 Should be float skillmodifier = (blockskill - attackskill) * 0.2325f; BG Wiki: BlockRate = SizeBaseBlockRate + ((ShieldSkill - AttackerCombatSkill) × 0.2325)

TeoTwawki commented 3 years ago

related: agi doesn't help parry either, and possibly doesn't help guard

ShiyoKozuki commented 3 years ago

Agility has no effect on any defensive skill besides evasion, crit rate against you, and subtle blow(is this even coded here?).

TeoTwawki commented 3 years ago

and subtle blow(is this even coded here?).

I'd wager the agi part of that is not but I didn't go looking.

LandSandBoat / server