LandSandBoat / server

:sailboat: LandSandBoat - a server emulator for Final Fantasy XI
https://landsandboat.github.io/server/
GNU General Public License v3.0
303 stars 614 forks source link

Battlefield timers are not updated by time extentions #911

Open TeoTwawki opened 3 years ago

TeoTwawki commented 3 years ago

Additional Information (Steps to reproduce/Expected behavior) : Battlefields that show the countdown clock in the top left corner do not get updated if the time is modified (time extensions) in any way. Chat log messages do function correctly with the updated time however, so this is a missing cosmetic feature and not a bugged time remaining. It will reach zero, stop, and then you will still have however many minutes/seconds remain before being kicked out.

zach2good commented 3 years ago

Good first issue: look inside battlefield.cpp at entry when we send out the timer packet. We should also be sending that out again on time updates. Notice that we send an empty timer packet to remove the timer (I think)

almuth150 commented 3 years ago

It also sends the full time value when entering after the battlefield has been initiated. So players who enter after the first one have their timers off by a little bit. If you wanted (or the battlefield was started while someone was afk and they entered 3 minutes late 😔), their timer would be 3 minutes off. It should send the current remaining time to subsequent entrants.

claywar commented 3 years ago

While thinking about this, can anyone confirm that the timer starts while an event is rolling for the first player to enter? I would assume yes