LandSandBoat / server

:sailboat: LandSandBoat - a server emulator for Final Fantasy XI
https://landsandboat.github.io/server/
GNU General Public License v3.0
289 stars 573 forks source link

mob's spikes bypass dmg immunity (and should not) #932

Open TeoTwawki opened 2 years ago

TeoTwawki commented 2 years ago

Additional Information (Steps to reproduce/Expected behavior) : Even gets through elemental sforzo and godmode.

They basically aren't calculating at all and are just deducting (and messaging) static numbers. I dunno how this made it through 4 iterations of projects to land in our lap in LSB but it'll be our problem now in the eyes of the end user.

ShiyoKozuki commented 2 years ago

No macc, mdt, mdb, or any type of check at all. Also wrong formulas and are doing basically double the damage they should be doing. https://github.com/LandSandBoat/server/issues/813

TeoTwawki commented 2 years ago

we know about the formulas and the issue you already opened thanks. this is about the fact they still land dmg when you are outright immune to damage of the type this is.

ShiyoKozuki commented 2 years ago

I'm saying there's multiple issues and we should perhaps merge them all into a single issue for spikes related things.

Edited. Please treat this as a Code of Conduct warning.

claywar commented 2 years ago

Edited the above comment. Please note that while the Code of Conduct is not expicitly stated in issue contributions, it is a general expectation of this forum.