search

LandSciTech / pfocal

Fast parallel convolution in R.
https://landscitech.github.io/pfocal/
Other
2 stars 1 forks source link

Next release to CRAN #31

Open VLucet opened 2 years ago

VLucet commented 2 years ago

@xlirate I have merged your changes into main, and fixed the covr issues, it should all be good now @see24 @josie-hughes we need to upload an update to CRAN asap (Josie is maintainer and will have to confirm the upload, so we might have to wait until she gets back)

see24 commented 2 years ago

@VLucet Great! @xlirate can you confirm that you were able to reproduce the error that CRAN was showing and have tested that your changes address it? I don't think the R-CMD checks we are ran on the PR would have caught it.

We can keep the package on CRAN if we submit the fix before July 8 so that would be good to aim for. Josie asked me to message her if we were ready to update the package on CRAN and she will submit it. So if you can confirm that we are sure it is fixed I will do that.

Thanks for both of your work on this!

xlirate commented 2 years ago

@see24, the error that we were seeing was one that I had previously fixed. In the pre-release versions of the package, I was doing some pointer arithmetic for a small performance gain that did not play nice with one of MAC's security measures. removing it fixes the issue. Something seems to have happened with the repo as the pre-removal code was back and failing again. I removed it again and it is working once more.

VLucet commented 2 years ago

@xlirate Im sorry, Im confused, is the current code on master good to go?

xlirate commented 2 years ago

I can only speak about the code on better_behaved. That is where I put the fix. I was expecting it to take up to a full rewrite, but got it done in a few lines. I did not merge it.

VLucet commented 2 years ago

That is what I merged so that is all good. Sorry for the confusion.

see24 commented 2 years ago

Ok Josie said she will try to update the CRAN version today

josie-hughes commented 2 years ago

I have submitted to CRAN. Thanks for your efforts!