search

LandSciTech / pfocal

Fast parallel convolution in R.
https://landscitech.github.io/pfocal/
Other
2 stars 1 forks source link

Deal with detected issues in R code #8

Closed VLucet closed 3 years ago

VLucet commented 3 years ago

See check:

> checking R code for possible problems ... NOTE
  .gaussian_strip_confidence: no visible global function definition for
    ‘qnorm’
  .gaussian_strip_radious: no visible global function definition for
    ‘pnorm’
  .p_focal_r: no visible binding for global variable ‘k’
  pFocal: no visible global function definition for ‘is’
  pFocal.stars: no visible global function definition for
    ‘layer_to_matrix’
  Undefined global functions or variables:
    is k layer_to_matrix pnorm qnorm
  Consider adding
    importFrom("methods", "is")
    importFrom("stats", "pnorm", "qnorm")
  to your NAMESPACE file (and ensure that your DESCRIPTION Imports field
  contains 'methods').
VLucet commented 3 years ago

Concerning 

.p_focal_r: no visible binding for global variable ‘k’

This is linked to this line which I am guessing in only for debugging purpose: k is not declared anywhere and will be sourced from global env which is problematic. We should declare a default value in the meantime.