Landscape-Data-Commons / terradactyl

Tools for using terrestrial core methods data
Other
3 stars 4 forks source link

Consider adding additional hits in gather_lpi function #125

Open calibretto21 opened 1 year ago

calibretto21 commented 1 year ago

Hi,

First, I want to say thank you for creating this awesome package, it has made my life so much easier!

We encountered a couple of sites this past season where we had up to 9 codes on a single LPI point... Would you consider making the following changes to your "gather_lpi" function to pick up these additional codes?

Identify the pin drop variables

pin_drop <- c( colnames(pintercept)[grepl( pattern = "^HIT[1-9]$", x = colnames(pintercept) )], "BASAL", "NONSOIL" )

rename Hit2-Hit9 as "LowerLayer

lpi_hits_tall$layer <- dplyr::recode( lpi_hits_tall$layer, "HIT2" = "Lower1", "HIT3" = "Lower2", "HIT4" = "Lower3", "HIT5" = "Lower4", "HIT6" = "Lower5", "HIT7" = "Lower6", "HIT8" = "Lower7", "HIT9" = "Lower8", )

There might be an easier way to do this but this is what I had to do to correctly ingest all of our data.

Thanks!

-Jason