Settings update timing bug fix

LaneDibello / Kotor-Randomizer

The Kotor Randomizer. A randomizer for Star Wars: Knights of the Old Republic. Intended for challenge runs and general fun.

4 stars 1 forks source link

Settings update timing bug fix #39

Closed glasnonck closed 3 years ago

glasnonck commented 3 years ago

Fixes #21.

Fix timing of updating form settings from on close to immediately.
- SoundForm
- ItemForm
- TextureForm
- PathForm
Added a method to quickly close all other windows from the StartForm (right-click menu).
Updated ItemForm's Omitted Items feature
- Added a reset button to go back to default settings.
- Text box will now add when Enter is pressed.
- Text box is cleared when an entry is added.
- Only allows lower case.
- Duplicate entries are not allowed.
Added path validation before randomizing.

LaneDibello commented 3 years ago

Forms mentioned have Settings update timing fixed. Though "TwoDa" still doesn't update settings (intentional?). The close all form method does work, however it can close the "Randomizing" form mid randomization, terminating the randomization and potentially causing serious problems. Omit Item features work/look great! Though the sound for the "Reset" button sounds alittle bit like an Error. Path Validation works as intended.

LaneDibello commented 3 years ago

Come to think of it, should we be able to close the Randomizing form while its running at all? After trying it a few times, I hit an exception.

LaneDibello commented 3 years ago

The listed features work correctly, however I encountered an unrelated issue during testing. See: #42