Save posts as drafts - Githubissues

LangCorrect / server

Master grammar, spelling, and syntax in the language(s) you’re learning through direct feedback on your writing from fluent, native speakers.

https://langcorrect.com

22 stars 12 forks source link

Save posts as drafts #419

Open elwinmartin opened 10 months ago

elwinmartin commented 10 months ago

Ideas for this:

maybe overlooking something but I think draft could just be a bool on the posts table rather than a new table
create page would only need an additional button next to publish
publish/draft button could even be the same API call as publish but with an added bool for is_draft
new page (My Drafts) would maybe be needed to view drafts would be a carbon copy of the setup for My Journals with is_draft
in my dreams you actually let drafts autosave like in most text editors but that would probably be easiest as a separate feature

elwinmartin commented 10 months ago

dunno when I'll have time to look at this myself but it's a really nice thing to have and I didn't see a feature request open yet

elwinmartin commented 10 months ago

Wait a minute https://github.com/LangCorrect/server/blob/80be6bb5b7a2c6b36e97d992928fa76f4b16ba6f/langcorrect/posts/models.py#L39C5-L39C14

So there's already a field for being a draft but it defaults to False and does nothing since the only check for it checks if it's False.

danielzeljko commented 10 months ago

in my dreams you actually let drafts autosave like in most text editors but that would probably be easiest as a separate feature

Those are my dreams too :-)

Yes -- that field is a placeholder for now. We used to have draft functionality back in the old codebase, but because both versions are completely different it would have to be worked on from scratch again.