search

LangProc / langproc-cw

Compiler coursework repository for Instruction Architectures and Compilers module at Imperial College London
19 stars 22 forks source link

Put build artifacts in build/ so as not to pollute src/ directory. #19

Closed SanjitRaman closed 4 months ago

SanjitRaman commented 4 months ago

make clean becomes simpler, and update gitignore to ignore build directory.

SanjitRaman commented 4 months ago

@Fiwo735 -- here is the pull request you have suggested I create.

Tested with make, make clean, and test.sh. However, the test.sh script seems to take a long time (recompiling everything) even though I had previously run make so all the artifacts are already in build/. Seeing as there have been a lot of changes to test.sh and test.py overnight, perhaps you have some insight as to why this is happening?

make coverage not tested.

Jpnock commented 4 months ago

@Fiwo735 -- here is the pull request you have suggested I create.

Tested with make, make clean, and test.sh. However, the test.sh script seems to take a long time (recompiling everything) even though I had previously run make so all the artifacts are already in build/. Seeing as there have been a lot of changes to test.sh and test.py overnight, perhaps you have some insight as to why this is happening?

make coverage not tested.

Does running with ./test.sh --dont-clean fix your performance issue?

We changed the python script to mirror the old behaviour of the bash script where it would always run make clean before testing (which is what we'll do when testing a compiler).

SanjitRaman commented 4 months ago

Does running with ./test.sh --dont-clean fix your performance issue?

Yes, it does -- perfect, I found an option called --no_clean.

We changed the python script to mirror the old behaviour of the bash script where it would always run make clean before testing (which is what we'll do when testing a compiler).

Ok. good to know that the option is there to allow quick testing with make (only recompiles the changed dependencies) and then ./test.sh --no_clean