search

LangProc / langproc-cw

Compiler coursework repository for Instruction Architectures and Compilers module at Imperial College London
19 stars 22 forks source link

Update Makefile #20

Closed dwRchyngqxs closed 4 months ago

dwRchyngqxs commented 4 months ago

Remove with_coverage as it is no longer needed

dwRchyngqxs commented 4 months ago

I'm wondering why there is an explanation to run a local webserver with python. The coursework directory is shared so they can just open the webpage with their webbrowser.

Fiwo735 commented 4 months ago

I'm wondering why there is an explanation to run a local webserver with python. The coursework directory is shared so they can just open the webpage with their webbrowser.

I think that was done so that it's easier to open directly through VSCode by clicking on the link in the terminal or the prompt that asks to open it in the default browser,

Jpnock commented 4 months ago

Remove with_coverage as it is no longer needed

I kept this for backwards compat reasons, since there's no harm in running the command (it just builds your compiler with coverage data as you'd expect) but for people using it they might get a bit confused once it no longer works for them

Fiwo735 commented 4 months ago

I kept this for backwards compat reasons, since there's no harm in running the command (it just builds your compiler with coverage data as you'd expect) but for people using it they might get a bit confused once it no longer works for them

Makes sense. hopefully they'd pull the newest version and notice that, but in any case I'll look out for any issues on Ed!