Renamed cli.h into cli.hpp, used structured bindings, made cli and compiler more consistent - Githubissues

LangProc / langproc-cw

Compiler coursework repository for Instruction Architectures and Compilers module at Imperial College London

19 stars 22 forks source link

Renamed cli.h into cli.hpp, used structured bindings, made cli and compiler more consistent #24

Open Fiwo735 opened 3 months ago

Fiwo735 commented 3 months ago

Just a small PR to clear some inconsistencies:

[x] cli.h remaned to cli.hpp to match other header files.
[x] Used structured binding to unpack command_line_arguments, leading to clearer intent and removed the need to pass the whole struct into functions.
[x] Some more comment documentation and tidying up in compiler.cpp, as that's where most students would look first.

Note the branch name changes, so that we now have:

main
dev: all ongoing development, especially useful when the coursework is in progress
<feature>: fresh branch created off dev branch each time, leading to a new PR

Jpnock commented 3 months ago

Also I like the main / dev / <other> branch naming idea; it works well for this repo I think.