search

LangProc / langproc-cw

Compiler coursework repository for Instruction Architectures and Compilers module at Imperial College London
19 stars 22 forks source link

Implemented a basic compiler that integrates lexer and parser + assembler directives explained #4

Closed Fiwo735 closed 5 months ago

Fiwo735 commented 5 months ago

As discussed over MS Teams.

Fiwo735 commented 5 months ago

Thanks for the review James, I really appreciate it! Saving hundreds of hours across the cohort was indeed my biggest motivation!

Re Makefile - brilliant changes, setting makefiles is not my strong point, but your version makes much more sense (and hopefully is even less error-prone for the students). Re Context - passing by reference was indeed my plan, but I simply mistyped it once and then copy-pasted wrongly in each place... thanks for spotting that!

I've left some minor comments in some of your suggestions above and committed the rest of them.