search

LangenGroup / RedPitayaSTCL

A scanning transfer cavity laser stabilization scheme based on the Red Pitaya STEMlab platform
GNU General Public License v3.0
10 stars 1 forks source link

Allows initialisation of LockClient with no moitor RP set #5

Closed mcgarc closed 5 months ago

mcgarc commented 6 months ago

We found when running the operation example with no monitor RedPitaya that set_monitor would fail. This appears to be a bug, as the doumentation indicates that it should be possible to run while using a separate oscilloscope to monitor the traces.

This pull request address this by making changes to the set_monitor method to check if a monitor RP is defined before attempting to retrieve it from the dictionary.

mcgarc commented 6 months ago

As I was writing the text for the PR, I noticed that there is already some intention of avoiding this bug in the code (check on len(self.monitors) == 0 in lockclient.py line 823). However, that doesn't seem to ever be activated for us, so I will investigate this further before submitting the PR.

mcgarc commented 5 months ago

Closing this as I can no longer reproduce this behvaiour.