LangilleLab / microbiome_helper

A repository of bioinformatic scripts, SOPs, and tutorials for analyzing microbiome data.
GNU General Public License v3.0
437 stars 205 forks source link

Added the RF_Utilities.R script used in my random forest tutorial. #40

Closed nearinj closed 5 years ago

nearinj commented 5 years ago

Would be great if someone looked over this real quick and also took a peak a the tutorial that I wrote, which can be found here:

https://github.com/LangilleLab/microbiome_helper/wiki/Random-Forest-in-R-with-Large-Sample-Sizes

gavinmdouglas commented 5 years ago

I can take closer look on Monday!

gavinmdouglas commented 5 years ago

I looked through the tutorial and overall it looks good although I think it could use some more tweaks. I made a few (very minor) edits already and you can see all of my comments below. The key thing is that I ran into an error when running the key RF command, which is something that needs to be troubleshooted.

Major

Minor

gavinmdouglas commented 5 years ago

It's hard to evaluate the R code without running actual tests, but one minor thing in the Rscript is that rather than the title Script to run the main RF pipeline I think saying that it contains R functions for running RF pipelines is more accurate.

gavinmdouglas commented 5 years ago

Last thoughts:

gavinmdouglas commented 5 years ago

@nearinj - friendly reminder about this PR so it isn't lost to the ages.

nearinj commented 5 years ago

Just saw this, I will look into this and fix it up ASAP.

nearinj commented 5 years ago

I have went ahead an uploaded my own package onto a github repo that can be installled using devtools. I will go ahead and link to this repo within the wiki tutorial and therefore not merge the changes in this pull request.

https://github.com/nearinj/RandomForestUtils