search

Language-Mapping / language-map

Front-end codebase for Language Mapping web map
https://languagemap.nyc
MIT License
7 stars 4 forks source link

SOW3.1.3: minor UI improvements #199

Closed abettermap closed 3 years ago

abettermap commented 3 years ago

Summary

Got a little sidetracked w/legend stuff but fonts are looking good. Just need deploy for now though...

Issues resolved by this pull request

abettermap commented 3 years ago

@rperlin-ela looking good and this will wrap up 3.1.3 i believe:

image

rperlin-ela commented 3 years ago

Stellar work— looking beautiful. Here's what I got:

abettermap commented 3 years ago

World Region thing happening on all Explore's, maybe result of #175 fix since it's not happening in prod, will look into it.

YouTube links: i haven't done anything with this so i'd suggest opening a new issue. Have you made any changes in AT? The link is working for me in the browser (e.g. this) so let me know if you changed anything (it doesn't look like it from what I can see in Airtable).

Also, did you do anything to your Google APIs token? We stopped using Sheets so just wondering if you dropped the API key or something, which could affect youtube if it's a separate key.

Will fix the vid/audio btn color.

Will try de-doubling and subtlizing the line. If you're still not on board, no worries on the buzzkill, was an experiment in elegance. 🤩

Let's see if we can improve on the text for "Map display options & legend"

Yeah I'm not digging it either. I think "Map display options" is so-so for the first part but maybe should mention "languages" somehow? Either way, I just put "legend" in there to save space but it really needs to be down near the actual legend.

Does this stir up any ideas, approval, or rejection?

image

abettermap commented 3 years ago

AH, you know what the issue might be with the youtube links? i'm wondering if your API settings aren't accepting hits from non-prod URLs. This works fine for example: https://languagemap.nyc/details/88

Pretty sure we've been able to visit deploy videos before though, that's how we reviewed it. Anyway it's not working for me locally either so i'm not sure what's up. Maybe hunt down your "allowed URLs" or whatever it's called in your Youtube API settings and screenshot it to me.

rperlin-ela commented 3 years ago

Screenshot stirs up some approval — if we can afford the space, that makes sense and looks pretty decent.

Speaking of that blue on the video button, I see now that it’s also being used in the Omnibox dropdown and would change that too. In that dropdown and the Census dropdown, the white line turns green on click — I think maybe it stay white or turn blue. This also applies to the search bar and the lines under the filters in Data.

I’ll check Youtube API settings later in the pm. Definitely haven’t done anything to the Youtube links, the API etc and a you say it works in prod (and links work in browser), and never had a deploy issue with this before.

On Mar 18, 2021, at 12:30 PM, Jason Lampel @.***> wrote:

AH, you know what the issue might be with the youtube links? i'm wondering if your API settings aren't accepting hits from non-prod URLs. This works fine for example: https://languagemap.nyc/details/88 https://languagemap.nyc/details/88 Pretty sure we've been able to visit deploy videos before though, that's how we reviewed it. Anyway it's not working for me locally either so i'm not sure what's up. Maybe hunt down your "allowed URLs" or whatever it's called in your Youtube API settings and screenshot it to me.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/pull/199#issuecomment-802082214, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5HBM3R7PJUQG5ZGXTTTEITBZANCNFSM4ZJMNE6Q.

abettermap commented 3 years ago

Speaking of that blue on the video button, I see now that it’s also being used in the Omnibox dropdown and would change that too. In that dropdown and the Census dropdown, the white line turns green on click — I think maybe it stay white or turn blue. This also applies to the search bar and the lines under the filters in Data.

Good catch(es)! Will fix. All those darker blues are our "secondary" color, needs to be the light version of that.

abettermap commented 3 years ago

all right man i gotta call it on this legend stuff, today was supposed to be for 3.1.4 and i haven't started yet. it's kind of an exercise in futility to try and cram all the stuff we want to see on load on mobile while remaining aesthetically and intuitively sound UI-wise, plus i keep forgetting that i still have to force the Location stuff in there somehow. i really don't want to lose the little bit of World Region legend that we see on mobile, but it's not very doable with all the stuff above, and at the same time not very intuitive to forego all headings for potentially less intuitive things like a bunch of dots and names and hope people know it's a legend, and understand what the controls above it affects.

anyway i think it looks okay as-is despite your opposition to the combined options/legend title. again, i'm not a fan either, but something's gotta give if we're going to indicate Legend-ness, maintain the relationship between that and the symb dropdown, and still have at least one row of World Region dots appear in the legend so mobile users have an actual chance of knowing that there's something below.

i made the other fixes (excluding youtube links, totally different thing) so unless there's an absolute deal-breaker i'd reeeeally like to merge this so i can keep the SOWmentum going, and we can circle back to the legend/home mess once we finish #195 and the Great Location Migration of '21.

rperlin-ela commented 3 years ago

Youtube links all good, so I guess it was a deploy issue!

Are the omnibox neighborhood names the same blue as everything else? Might just be my eyes, and against the black

abettermap commented 3 years ago

you've sure got an eye for catching those 😃 yeah I'll change it.

hey isn't that the wrong icon?

image

we've been using this for neighbs and "Local":

image

i'm also fine scrapping the icon in there, it's pretty redundant and not consistent with the rest of the UI anyway since it describes Town OR Neighb.

we're also using the "Local" icon in the table column headings in addition to Neighb-ness. fine i guess but slightly misleading since it applies to Town rows in the table as well.

abettermap commented 3 years ago

i know you're not a fan of repetitive icons, not to mention the light text stands out better anyway (not what i have in screenshot), so i'm going to axe the icons from omni!

abettermap commented 3 years ago

your addition of borough names also makes it obvious that they're locations (i imagine MOST users have heard the borough names). so icons are even less important in that sense.

abettermap commented 3 years ago

cool?

image

rperlin-ela commented 3 years ago

Cool, good call

On Mar 18, 2021, at 5:09 PM, Jason Lampel @.***> wrote:

cool?

https://user-images.githubusercontent.com/4974087/111697991-e72d9f80-87fb-11eb-9e46-fb3f8441ee50.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/pull/199#issuecomment-802300994, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5AD6T5S57Q4VAFX4RDTEJTZFANCNFSM4ZJMNE6Q.

rperlin-ela commented 3 years ago

I know we didn’t discuss this (apologies!), but at Explore/Languages, now that we switched Endo and Language, can we change that top text from “Common langauge name in English” to “Common language name in English and in the language itself (endonym)"

On Mar 18, 2021, at 5:10 PM, Ross Perlin @.***> wrote:

Cool, good call

On Mar 18, 2021, at 5:09 PM, Jason Lampel @. @.>> wrote:

cool?

https://user-images.githubusercontent.com/4974087/111697991-e72d9f80-87fb-11eb-9e46-fb3f8441ee50.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/pull/199#issuecomment-802300994, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5AD6T5S57Q4VAFX4RDTEJTZFANCNFSM4ZJMNE6Q.

abettermap commented 3 years ago

YOU can, it's in the Schema table in AT. Just note that it's also used in the card at top-level Explore view, so try to make it sure it semi-applies to both.

If you want something beyond that, sorry but I'm not going to customize my /Explore/Something intro component just for that. It's not a question of time or SOW either, it's that there are so many tiiiny variations like that between what would otherwise be consistent code, and it's kind of just adding another layer of "weather resistant plywood" (or whatever I called it) to our fragile little code house.

The right way to do that though would be another column in AT for that level of Explore. Then it's maintainable and data-driven like the rest of the Explore config (except icons, I hardcoded those).

rperlin-ela commented 3 years ago

No this is perfect, forgot about that, just changed it, mind blown 🤯

On Mar 18, 2021, at 6:07 PM, Jason Lampel @.***> wrote:

YOU can, it's in the Schema table in AT. Just note that it's also used in the card at top-level Explore view, so try to make it sure it semi-applies to both.

If you want something beyond that, sorry but I'm not going to customize my /Explore/Something intro component just for that. It's not a question of time or SOW either, it's that there are so many tiiiny variations like that between what would otherwise be consistent code, and it's kind of just adding another layer of "weather resistant plywood" (or whatever I called it) to our fragile little code house.

The right way to do that though would be another column in AT for that level of Explore. Then it's maintainable and data-driven like the rest of the Explore config (except icons, I hardcoded those).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/pull/199#issuecomment-802338169, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5AK7Z6SQXK6XHBU55DTEJ2SPANCNFSM4ZJMNE6Q.

abettermap commented 3 years ago

Woo, AT save!

abettermap commented 3 years ago

not sure where to ask this but can we axe the icons here too?

image

i imagine i talked/forced you into keeping them but not as necessary w/boroughs now...

rperlin-ela commented 3 years ago

Was just thinking about that earlier — axe away!

On Mar 18, 2021, at 6:51 PM, Jason Lampel @.***> wrote:

not sure where to ask this but can we axe the icons here too?

https://user-images.githubusercontent.com/4974087/111707632-0a5f4b80-880a-11eb-87e9-74d531bcfafd.png i imagine i talked/forced you into keeping them but not as necessary w/boroughs now...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/pull/199#issuecomment-802363710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5CKFJP3K6SJPTPBZXDTEJ7WJANCNFSM4ZJMNE6Q.

abettermap commented 3 years ago

axed. i wish we had something more for these guys though:

image

pretty sparse and repetitive but it's not really card-worthy with just the Location name. not sure what to do w/those really.

rperlin-ela commented 3 years ago

You’re right, I’m open. “View details and show in map” may not be necessary either, especially if they light up blue like other Explore cards. De-card if you think of something better (in Data, we do already have a “View in map” icon aka “Show in map” on hover). If keeping the card, there’s probably not enough room to show a bit of Description, and for now they’re still mostly repetitive anyway. I’d consider putting some other kind of tidbit in there, but I know that’ll be more work!

On Mar 18, 2021, at 7:06 PM, Jason Lampel @.***> wrote:

axed. i wish we had something more for these guys though:

https://user-images.githubusercontent.com/4974087/111708800-1d731b00-880c-11eb-986f-ab7ecf180aba.png pretty sparse and repetitive but it's not really card-worthy with just the Location name. not sure what to do w/those really.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/pull/199#issuecomment-802371368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5AMZT673IKLE5JS6YDTEKBP7ANCNFSM4ZJMNE6Q.

abettermap commented 3 years ago

If keeping the card, there’s probably not enough room to show a bit of Description

I thought we had that before but axed it since they were so similar to each other? Or is that different now with the instance/lang-level split on descriptions?

rperlin-ela commented 3 years ago

Can’t get anything past you, huh? We did try it, and they still are too similar for the most part. I’m gradually making inroads. Let me know if you think this would be easy (on your end) and actually look good...

On Mar 18, 2021, at 8:31 PM, Jason Lampel @.***> wrote:

If keeping the card, there’s probably not enough room to show a bit of Description

I thought we had that before but axed it since they were so similar to each other? Or is that different now with the instance/lang-level split on descriptions?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/pull/199#issuecomment-802413223, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5DSHNXJQRMAHYU2IPDTEKLMTANCNFSM4ZJMNE6Q.

abettermap commented 3 years ago

Easy, just needs... 2-3 more AT columns haha

Not related to this scope in any way though so I'd better stop throwing ideas out there, already added quite a bit of goodies that was pretty gray-area SOW-wise and although we've been steadily cranking this week, there's a lot more on the docket and some monster tasks in there as well. Gotta stay on track but I'd encourage you to make issues for these things. I feel like a broken record saying that, but I spend a LOT of time writing and maintaining GH issues, so it'd be appreciated if you would document your own wishlist stuff like this and the Read More thing. I think they're both legit ideas but I don't want either of them so bad that I'll write up the issue. It's truly the perfect way to document though, will never get lost in the ether!