search

Language-Mapping / language-map

Front-end codebase for Language Mapping web map
https://languagemap.nyc
MIT License
7 stars 4 forks source link

SOW3.1.4: smaller new feature additions #201

Closed abettermap closed 3 years ago

abettermap commented 3 years ago

Issues resolved by this pull request

abettermap commented 3 years ago

@rperlin-ela i got a late start today so decided to push on through like the good ol' days, so have a look at the 3 issues i included in this PR so far when you get a chance. there's some quirks with 2D/3D toggle on mobile, i had problems w/that before, so i'll give a fresh look tomorrow but may have to circle back to that another time. it's all definitely working but i just can't get it to center properly on mobile when toggling, and it's very apparent when a popup for selected community is present.

rperlin-ela commented 3 years ago

Quick look on desktop before shutting down for the night but all looking good, can commit or wait as you like in the morning.

abettermap commented 3 years ago

Thanks, I'll keep plugging away on this branch. I'm trying to get in the habit/convention of

"WIP" in the PR title + not assigning you as Reviewer = not ready for primetime yet

If no WIP and you're Reviewer, it's ripe for the pickin.

abettermap commented 3 years ago

@rperlin-ela all set for review. still would like to punt these until Week 4 if they're of concern:

  1. 2D/3D (#194): if popup is present when this button is toggled on mobile, zoom/pan centered properly in the map (it's offset in 3D right now but wasn't before when we just had the "reset pitch" btn)

  2. 195 : if you're not seeing it, or if you are and don't feel it's a problem, case closed. or if you want to take the quick and dirty way out, that's simply adjusting text.