search

Language-Mapping / language-map

Front-end codebase for Language Mapping web map
https://languagemap.nyc
MIT License
7 stars 4 forks source link

Remaning Neighborhood tasks #225

Closed abettermap closed 3 years ago

abettermap commented 3 years ago

(from #222)

Later

(moving to new issue)

abettermap commented 3 years ago

@rperlin-ela as far as next steps/priorities go, after #217 is merged, what are we leaning towards? some big focuses, so let's pick one:

  1. the issue above, minus "support auto zoom on initial page load", which i don't think i'll be able to fix, at least not without burning another day literally just for that edge case. if i don't fix though, that means we shouldn't include Share btns in /Explore/Neighb/Something like i suggested. got bigger fish to fry anyway!
  2. abstracting/refactoring and genericizing the neighbs code in preparation for counties and census
  3. tooltips on hover for points. FYI could lose a day on this as well. i'm not doing this for polygons, sorry. i think all the other non-SOW things i've added should make up for what might have been a potentially annoying addition (for polygons, not points) anyway.
  4. other little minor fixes and tweaks that keep popping up

i could certainly do # 2 while the data is being prepped, but it might be easier once it's ready.

#1 is probably the most gratifying and directly applicable to neighborhoods, and i'm terrified of # 3 after the major related defeats i faced in the last couple days, and # 4 seems better for later in the week.

so # 1 i guess is my vote, but any thoughts?

rperlin-ela commented 3 years ago

No talk of defeat. I vote for 1 also. Yeah, scrap the share btns.

abettermap commented 3 years ago

Sweet, if I ever fix the on load issue, I can add the share. They are not difficult, but the auto zoom problem is.

Just to confirm, we don't need any toggle to enable/disable auto zoom in the explore panels for neighborhoods and counties, correct? I don't find it annoying in the least, especially when neighborhoods layer is not visible.

rperlin-ela commented 3 years ago

Nah I think it’s fine to auto-zoom people around

On Mar 31, 2021, at 2:19 PM, Jason Lampel @.***> wrote:

Sweet, if I ever fix the on load issue, I can add the share. They are not difficult, but the auto zoom problem is.

Just to confirm, we don't need any toggle to enable/disable auto zoom in the explore panels for neighborhoods and counties, correct? I don't find it annoying in the least, especially when neighborhoods layer is not visible.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/225#issuecomment-811305279, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5BHT6WDNGBU7DAEYI3TGNRRPANCNFSM42FFNW3A.

abettermap commented 3 years ago

FYI you've got at least one neighborhood w/trailing space:

image

abettermap commented 3 years ago

Unrelated, but THIS happened:

image

which is a step up from current:

image

run with it??

abettermap commented 3 years ago

definitely better w/just 3 lines preview:

image

rperlin-ela commented 3 years ago

Love it — inspires me to keep churning out the words!

On Mar 31, 2021, at 6:58 PM, Jason Lampel @.***> wrote:

definitely better w/just 3 lines preview:

https://user-images.githubusercontent.com/4974087/113221450-4b138780-9242-11eb-802c-dd5fd7aad64c.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/225#issuecomment-811518982, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5FCKRSBHVXCNODOUK3TGOSJZANCNFSM42FFNW3A.

abettermap commented 3 years ago

words are lookin good, keep em coming.

the toggle was easy to wire up:

image

  1. can we remove the "i"?
  2. placement and size good enough?
abettermap commented 3 years ago

Neighborhoods are shown within NYC's five boroughs, and counties (coming soon) for the surrounding areas. Source: NYC Census 2020 map

current the "i" popout has that. i'm not hatin' on the "i", just wondering if the text could go in your /Explore/Neighborhoods intro, or About or Help?

rperlin-ela commented 3 years ago

Good call, don’t need that “i”, will get the message across.

On Mar 31, 2021, at 7:43 PM, Jason Lampel @.***> wrote:

Neighborhoods are shown within NYC's five boroughs, and counties (coming soon) for the surrounding areas. Source: NYC Census 2020 map

current the "i" popout has that. i'm not hatin' on the "i", just wondering if the text could go in your /Explore/Neighborhoods intro, or About or Help?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/225#issuecomment-811535103, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5GNKJRL5OZ5I4WRX4DTGOXSZANCNFSM42FFNW3A.

abettermap commented 3 years ago

axed.

oh and here's how it's looking w/your summary:

image

and without any primaries or summary:

image

sufficient?

i like it but only thing i might add is the "clear selection" btn. it's semi-disorienting and frustrating to not be able to jump ship. not sure where clear would take you, maybe just to /Explore/Neighborhoods? i know we can do that in like four different ways haha, but an escape hatch isn't terrible. can call it "Show all neighborhoods" or something, and can just be a link text instead of button.

how about after you answer the other things first, i push up what i have and you can play around to see what you think? the clear would be easy, just let me know

abettermap commented 3 years ago

after looking at Holliswood for a sec, seems like we could use some indication that there are no primaries. "additional languages" doesn't make as much sense in this context. easiest would be to just reword that part, as long as it still makes sense across the board.