Search Locations: increase open list height

[abettermap]

One more thing for the Search Locations tab when we get there— unlike with Search Languages (and unlike, I think, how location search used to be back in the bad old "Local" days), only one search result is now visible until you scroll down. Would be great for that dropdown to go on top of other stuff so searchers can see a bunch of options.

Originally posted by @rperlin-ela in https://github.com/Language-Mapping/language-map/issues/204#issuecomment-811082887

[abettermap]

Yeah I noticed this. The containing element around those tabs when it's toggled on has a maximum height set so that the smooth animation can occur when you toggle it open or closed. I could just make it a regular toggle without a maximum height, but we would lose the smooth open/close.

If I'm able to make it look like it appears above The panel below it, I will do that instead. Seems possible since that's what the omnibox search box does.

[rperlin-ela]

Leave the approach to you, but this is definitely important— now I'm not even seeing the top result

[abettermap]

yikes, ok i'll try to knock this one out today

[abettermap]

good to go i think, the only difference layout-wise is that it "pushes down" the stuff below it, which is a neutral impact IMO and looks fine to me:

to offset that a bit, i also dropped down the results limit to 3 instead of 5 (default).

cool?

[rperlin-ela]

Looks good to me

On Apr 6, 2021, at 2:19 PM, Jason Lampel @.***> wrote:

 good to go i think, the only difference layout-wise is that it "pushes down" the stuff below it, which is a neutral impact IMO and looks fine to me:

to offset that a bit, i also dropped down the results limit to 3 instead of 5 (default).

cool?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.