search

Language-Mapping / language-map

Front-end codebase for Language Mapping web map
https://languagemap.nyc
MIT License
7 stars 4 forks source link

Restore Gentium #228

Closed abettermap closed 3 years ago

abettermap commented 3 years ago

I added some checks to remove fonts during local development but looks like it slipped into other environments somehow. Just need to restore so the fonts look right…

abettermap commented 3 years ago

@rperlin-ela i think i was on the wrong track, nothing to do w/my font stuff, it was actually the markdown conversion thing since i started using that for Details too.

i think you're wanting this:

image

rather than this?

image

first one is an actual paragraph, which has more line-height. looks easier to read to me, so go with that?

abettermap commented 3 years ago

either way, if that's not it, i think the first one looks good so rolling with it unless disagreement!

btw i'm not going to restore my "don't load fonts on local dev" even though that wasn't the problem. the lack of the proper fonts makes it way too different to style anything and work with layouts. lesson learned!

rperlin-ela commented 3 years ago

nice, yes

On Apr 1, 2021, at 12:27 PM, Jason Lampel @.***> wrote:

@rperlin-ela https://github.com/rperlin-ela i think i was on the wrong track, nothing to do w/my font stuff, it was actually the markdown conversion thing since i started using that for Details too.

i think you're wanting this:

https://user-images.githubusercontent.com/4974087/113324739-b60d9e80-92d4-11eb-843f-8315cc7216ab.png rather than this?

https://user-images.githubusercontent.com/4974087/113324783-c0c83380-92d4-11eb-93d0-16e0ef751d34.png first one is an actual paragraph, which has more line-height. looks easier to read to me, so go with that?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/228#issuecomment-812023360, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5ASFYV6OO5HMFUQRG3TGSNHJANCNFSM42FJMFCA.