search

Language-Mapping / language-map

Front-end codebase for Language Mapping web map
https://languagemap.nyc
MIT License
7 stars 4 forks source link

Census: remaining tweaks & fixes #242

Closed abettermap closed 3 years ago

abettermap commented 3 years ago

...excluding the #207 stuff.

abettermap commented 3 years ago

@rperlin-ela i think i know enough answers to get started, but let me know when you have a chance

rperlin-ela commented 3 years ago

Will take a look but tied up so probly not till tonight

On Apr 4, 2021, at 1:13 PM, Jason Lampel @.***> wrote:

 @rperlin-ela i think i know enough answers to get started, but let me know when you have a chance

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

rperlin-ela commented 3 years ago

An excellent list — I think I agree with all of it.

  • [ ] Census popout: "view in map" goes to /Census but shouldn't it just close the popout rather than change pages?

Good call.

  • [ ] "Clear census" link in map menu: still doing this even though it's not a toggle? seems intuitive enough in census popout so that's my vote. If including, where? below "show/zoom my loc" helper and above basemap stuff? does it need helper text? hopefully not, it's getting a little busy in the menu and "clear census XXXXX" seems sufficient if we have a good XXXXX, like ___

Right on

  • [ ] Census dropdown: can we have smaller group headings for puma and tract? there's a lot going on in there with all that text (takes up a serious amt of space on mobile) and it seems like with all the new text in the panel we should be able to explain what the group headings currently explain, but above or below the dropdown?

Makes sense. It's good now, but I could see that it would probably be work if I can just work in the secondary text for both tracts and PUMAs somewhere in the the rest of the text.

abettermap commented 3 years ago

Sounds good.

we have a good XXXXX, like ___

I was hoping you'd fill in the blank there. ;)

rperlin-ela commented 3 years ago

XXXXX sometimes marks the spot, but my brain is a little fried right now and I'm stumped. The Clear Census button in the pop-out is a good model— disabled unless a census layer is on, right? Don't think it needs helper text. Could even just be "Clear Census", no? I guess "Clear Census Language Data" or that kind of that is better, if longer. Or do you mean dynamically filling in depending on what language layer is on?

abettermap commented 3 years ago

I guess "Clear Census Language Data" or that kind of that is better, if longer

ok i'll run with that, but if there's any requests to change it then it's going into UI Text table in AT. the wording stuff is kinda draining and it derails progress on my end so it's worth the few minutes to wire it up and put the ball in your court!

Or do you mean dynamically filling in depending on what language layer is on?

no, nothing crazy like that, just the wording of the text 24/7.

Fix census popup text (show pretty name, not field name)

i can't reproduce this except on page load, like if i go to /Census/puma/F3113__Panjabi/3604105 then hit refresh, it happens. but i can't make it happen in the UI otherwise. are you experiencing it?

rperlin-ela commented 3 years ago

I hear you — trying my best! But definitely slam anything you like into UI Text.

With census pop-up yeah: I click a point on the map, click the census pop-out, then click on one of the PUMAs or Tracts and I get the non-pretty name. Going via Omnibox it’s the same, mobile or destkop. Doesn’t happen to you — or am I misunderstanding?

On Apr 4, 2021, at 9:28 PM, Jason Lampel @.***> wrote:

I guess "Clear Census Language Data" or that kind of that is better, if longer

ok i'll run with that, but if there's any requests to change it then it's going into UI Text table in AT. the wording stuff is kinda draining and it derails progress on my end so it's worth the few minutes to wire it up and put the ball in your court!

Or do you mean dynamically filling in depending on what language layer is on?

no, nothing crazy like that, just the wording of the text 24/7.

Fix census popup text (show pretty name, not field name)

i can't reproduce this except on page load, like if i go to /Census/puma/F3113__Panjabi/3604105 then hit refresh, it happens. but i can't make it happen in the UI otherwise. are you experiencing it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/242#issuecomment-813135853, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5DTYV3FXHV7UOB6QE3THEG43ANCNFSM42LS3U7A.

abettermap commented 3 years ago

so i tried this flow just now:

  1. fresh load from Home
  2. Click Census nav btn
  3. Click search box
  4. Click Urdu
  5. Click a map polygon

result:

image

not the case for you?

abettermap commented 3 years ago

OH from the popout. nvm i got it, will fix

rperlin-ela commented 3 years ago

Sorry maybe I’m mixing up pop-out and pop-up. From Census panel, totally, there’s no problem, I’m talking about the Census chip in Lg Profile or Details. It’s when I go via that route.

On Apr 4, 2021, at 9:37 PM, Jason Lampel @.***> wrote:

so i tried this flow just now:

fresh load from Home Click Census nav btn Click search box Click Urdu Click a map polygon result:

https://user-images.githubusercontent.com/4974087/113528193-1fafd600-957d-11eb-9b24-c7a42c21a8d2.png not the case for you?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/242#issuecomment-813137596, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5HJDK5IFMJU5YPKFETTHEH5TANCNFSM42LS3U7A.

abettermap commented 3 years ago

no i gotcha, i'm getting it too, will just have to hit AT Schema table to grab the pretty name. easy fix.

how's this for map menu?

image

rperlin-ela commented 3 years ago

I dig. View options just takes you to Census panel I assume

On Apr 4, 2021, at 10:01 PM, Jason Lampel @.***> wrote:

no i gotcha, i'm getting it too, will just have to hit AT Schema table to grab the pretty name. easy fix.

how's this for map menu?

https://user-images.githubusercontent.com/4974087/113529392-8256a100-9580-11eb-820c-f5769cea485f.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/242#issuecomment-813142194, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5BAA2XCTNFYFABMZELTHEKX5ANCNFSM42LS3U7A.

abettermap commented 3 years ago

affirmative

abettermap commented 3 years ago

i dropped the bold on "Census data:" is all. stands out too much.

abettermap commented 3 years ago

actually i'm feeling the View options link first since it will be enabled always, whereas Clear selection makes it harder to identify that both of those links pertain to Census:

image

rperlin-ela commented 3 years ago

Looking good

On Apr 4, 2021, at 10:10 PM, Jason Lampel @.***> wrote:

actually i'm feeling the View options link first since it will be enabled always, whereas Clear selection makes it harder to identify that both of those links pertain to Census:

https://user-images.githubusercontent.com/4974087/113529781-a2d32b00-9581-11eb-97ec-cc45b743bad0.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/242#issuecomment-813144140, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5AW5GI4CUAQXET7ESDTHELYJANCNFSM42LS3U7A.

abettermap commented 3 years ago

gonna have to throw in the towel on the selected census feature highlight. i got it to work but it oil spills everything else:

image

super complicated, hard to explain, got an hour into it and just not worth it. we'll have to settle for the dynamic fill colors and auto-zoom and popup on click.

not sure there's a one-size-fits-all highlight color for the census layers anyway since their fills are so dynamic, where as counties and neighbs are same 24/7.

i did find simple ways to make the highlighted feat stand out on those though:

image

abettermap commented 3 years ago

ok i think i'm all set on census stuff except for #207 which i'll get tomorrow.

pushed my other stuff though, give it a look. more info in commit log.

abettermap commented 3 years ago

If you'll consider shorter group headings for census dropdown let me know, they take up about 20% of the available vertical space on my phone, and it's not a very small phone.

image

abettermap commented 3 years ago

This seems to sum it up enough and you can elaborate more about which one is used when available in your paragraphs maybe?

image

rperlin-ela commented 3 years ago

Perfect, sure

On Apr 5, 2021, at 12:57 AM, Jason Lampel @.***> wrote:

 This seems to sum it up enough and you can elaborate more about which one is used when available in your paragraphs maybe?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

abettermap commented 3 years ago

cool. i gave you two more UI Text rows just in case ;)

abettermap commented 3 years ago

found a quirk about how i'm calculating the "center" of a polygon based on its bounds corners:

image

it's just doing its job here, but the popup is actually referring to the larger polygon, not the lil guy in the middle. it's definitely in the center of the big one, but also... the little one. i don't think there's an easy fix for that one, so just pointing it out.