search

Language-Mapping / language-map

Front-end codebase for Language Mapping web map
https://languagemap.nyc
MIT License
6 stars 4 forks source link

The word "table" on the Data panel #250

Closed rperlin-ela closed 3 years ago

rperlin-ela commented 3 years ago

Tiny pet peeve here, but when the Data table opens up "full screen" I still see and can't quite unseen the word "table" behind it back on the panel itself. Any word to axe it or make it read "Data"?

abettermap commented 3 years ago

ha i was just noticing that tonight. yeah easy fix, i just have all the panel titles based on the route.

the easiest fix would just be to rename the route to /Data instead of /table, as well as its child route to /Data/:id (when full screen Details view is shown via table).

any problems with that?

abettermap commented 3 years ago

actually it doesn't make sense to have a panel title at all, so i'll just hide it. speaking of panel titles though, i'd like to see them in ALL views. will start a new issue w/some ideas, and it's a good segway from this thread.

rperlin-ela commented 3 years ago

Good, cool. Yeah, good discussion to have. Still also rethinking a few of those names we just kind of threw in — can discuss in the new thread

On Apr 6, 2021, at 9:43 PM, Jason Lampel @.***> wrote:

actually it doesn't make sense to have a panel title at all, so i'll just hide it. speaking of panel titles though, i'd like to see them in ALL views. will start a new issue w/some ideas, and it's a good segway from this thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/250#issuecomment-814540126, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5FHRI6ANKURATPF23TTHO2FLANCNFSM42PZXKWA.