search

Language-Mapping / language-map

Front-end codebase for Language Mapping web map
https://languagemap.nyc
MIT License
7 stars 4 forks source link

External links now broken? #264

Closed rperlin-ela closed 3 years ago

rperlin-ela commented 3 years ago

I think there may be a new issue with all external links resolving locally. See the "Read more here" at https://languagemap.nyc/Explore/Language/Sicilian/1007 or https://languagemap.nyc/Explore/Language/Wakhi/1205 for examples. Also from the Data table.

Originally posted by @rperlin-ela in https://github.com/Language-Mapping/language-map/issues/261#issuecomment-818062720

abettermap commented 3 years ago

i think the only way i'll be able to make this work is if the relative (internal) links are consistent. not sure how we/you normally enter them but i just did a test with:

/Info/About

...exactly like that, as the URL when i highlight the word Test and paste that text in:

image

this comes back as i expect in the browser:

image

...which is total garbage, but it's consistent garbage that i can work with.

i confirmed this is how i did it in the none-selected AT text as well:

image

so just make sure your internal links are like that, and i'll treat the normal links as external. those ones i don't think we have any way for you to specify if they should open in a new tab, so i'll just make them all do that.

i also noticed both the links are bad (in different ways) in explore-intro in UI Text, so might want to fix those.

abettermap commented 3 years ago

oh and i've seen a few like /info/About when the route is actually /Info/About. again, best way to get it exact is just copy it from the actual URL.

the only route i've changed is /table to /Data but all the rest should be /Something capitalized first letter.

abettermap commented 3 years ago

my guess on the explore-intro is that there wasn't a slash at the beginning:

image