search

Language-Mapping / language-map

Front-end codebase for Language Mapping web map
https://languagemap.nyc
MIT License
7 stars 4 forks source link

Post- post review #270

Closed abettermap closed 3 years ago

abettermap commented 3 years ago
abettermap commented 3 years ago

@rperlin-ela

the "fix" for #218 is something that's part of some reallllly nasty convoluted messes which have to do with the table filters, clearing them, auto-zoom. so, not something i'm really inclined to include in prod comfortably as the very-last thing i do before docs. if you want to test it really hard (filtering, clearing filters, clicking map point as quickly as possible, reloading page from a point, etc.), let's go for it. but if you find anything fishy whatsoever regarding that stuff, let's scrap it. it's a small commit that's easy to undo and would only take a minute.

it's only wired up to prevent the unwanted zoom-to-full when a County, Neighb, or lang point is selected. doesn't matter if via click or page refresh.

in other words if you start from /Census/puma/something/something via reload, you'll still get the accidental zoom. i figured those aren't advertised and aren't shareable though, so seemed like an edge case.

holler as soon as you have a conclusion. happy to scrap as i think it's part of a massive intertangled mess which could take a day or two to resolve.

abettermap commented 3 years ago

not sure if i need to repeat this since we've got the PR flow down, but just make sure to review each of the issues closed above

abettermap commented 3 years ago

forgot about icon too. let me know if you're not sure how to test the iOS tile icon. it's just "Add to Home Screen" from Safari share menu on iphone/pad.

abettermap commented 3 years ago

sorry to be a last-minute-johnny here but i just fixed #271 as well. should work fine on mobile now.

abettermap commented 3 years ago

deploy in a few minutes...

abettermap commented 3 years ago

Nice. 218 was when you click a point on the map as soon as possible after load, and then it kicks you back out to the full extent. Similarly if you started a page from a selected point, like hitting refresh or whatever, same thing.

Sounds like the Band-Aid worked though, merging.