Language-Mapping / language-map

Front-end codebase for Language Mapping web map
https://languagemap.nyc
MIT License
7 stars 4 forks source link

Details: add media section #68

Closed abettermap closed 4 years ago

abettermap commented 4 years ago

Summary

Set up details panel to have embeds for:

Related

67 has details stuff sprinkled in, and I missed a reply:

Will there actually be a good way for people to find all the ones that have video?

Hmm could maybe throw a "Video" column at the end of the table.

abettermap commented 4 years ago

Ok @rperlin-ela what ya think?

A

image

B

image

abettermap commented 4 years ago

If it makes a difference, I could add at least a "Video" column to the end of the table.

rperlin-ela commented 4 years ago

Column (with just a checkbox for those that have a video — sortable?) sounds like a good idea if it’s not too much trouble.

Here’s a middle ground between A/B, let’s just do Video and Audio. Leave Story Map out entirely for now. I’ll take it out of the next tileset.

On Aug 31, 2020, at 2:28 PM, Jason Lampel notifications@github.com wrote:

If it makes a difference, I could add at least a "Video" column to the end of the table.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/68#issuecomment-683951415, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5BRM527NZ7LAPMQ55TSDPTWXANCNFSM4QQYKBCA.

abettermap commented 4 years ago

Save it for Year 2 then? Fine by me, will take it out of code.

Hey can you standardize your YouTube URLs a bit? I'm fine replacing a few patterns on my end but there's quite a few variations so I think it makes more sense to fix on your end.

Here is the proper URL for a playlist embed:

https://www.youtube.com/embed/videoseries?list=PLAYLIST_ID_GOES_HERE

Here is the proper URL for a video embed:

https://www.youtube.com/embed/VIDEO_ID_GOES_HERE

For reference: Google help and this answer

In the interim I will do a couple replacements dynamically just so I can have something to play with and make sure it's working.

Cool?

rperlin-ela commented 4 years ago

All good, thanks.

On Aug 31, 2020, at 2:52 PM, Jason Lampel notifications@github.com wrote:

Save it for Year 2 then? Fine by me, will take it out of code.

Hey can you standardize your YouTube URLs a bit? I'm fine replacing a few patterns on my end but there's quite a few variations so I think it makes more sense to fix on your end.

Here is the proper URL for a playlist embed:

https://www.youtube.com/embed/videoseries?list=PLAYLIST_ID_GOES_HERE

Here is the proper URL for a video embed:

https://www.youtube.com/embed/VIDEO_ID_GOES_HERE

For reference: Google help https://support.google.com/youtube/answer/171780?hl=en and this answer https://stackoverflow.com/a/25661346 In the interim I will do a couple replacements dynamically just so I can have something to play with and make sure it's working.

Cool?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/68#issuecomment-683964392, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5GHFEQWSX5ZA773FNDSDPWPPANCNFSM4QQYKBCA.

abettermap commented 4 years ago

Removed all mentions of "story map" in the code, and videos are ready (or at least the ones which I'm dynamically fixing if they start with https://www.youtube.com/playlist?list=, but the rest should be ready once you upload the newest tileset). Video definitely adds a new level of "cool app" status. Fun!

https://deploy-preview-69--languagemapping.netlify.app/

The audio one(s) will be more challenging. I thought it was SoundCloud but not so much. Will have to look into this one. Or you can create an ELA SoundCloud acct, upload the track, and save me some time. :)

I'm half-joking, but it would certainly standardize the audio aspect. The embeds are super easy and will be consistent cross-platform.

rperlin-ela commented 4 years ago

I think it’s pretty great—elegant, simple, works.

We do have a Soundcloud account, so feel free to test https://soundcloud.com/elalliance/urgen-entry-1?in=elalliance/sets/urgen-dolpo-diary https://soundcloud.com/elalliance/urgen-entry-1?in=elalliance/sets/urgen-dolpo-diary for Dolpo, or let me know how you’d need the URL.

But it would be pretty key to do Archive.org http://archive.org/ instead or in additon, to be honest, because Soundcloud has all kinds of other limitations for us as a place to store audio (starting with cost) and we’re 95% sure that Archive.org http://archive.org/ is going to play a part in our longterm archiving strategy (which is a whole other story). Take a look when you can and let me know how challenging it looks.

Confirming that new tileset coming soon will not have a Story Map column but will have a Font URL column.

On Aug 31, 2020, at 4:26 PM, Jason Lampel notifications@github.com wrote:

Removed all mentions of "story map" in the code, and videos are ready (or at least the ones which I'm dynamically fixing if they start with https://www.youtube.com/playlist?list=, but the rest should be ready once you upload the newest tileset). Video definitely adds a new level of "cool app" status. Fun!

https://deploy-preview-69--languagemapping.netlify.app/ https://deploy-preview-69--languagemapping.netlify.app/ The audio one(s) will be more challenging. I thought it was SoundCloud but not so much. Will have to look into this one. Or you can create an ELA SoundCloud acct, upload the track, and save me some time. :)

I'm half-joking, but it would certainly standardize the audio aspect. The embeds are super easy and will be consistent cross-platform.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/68#issuecomment-684018779, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5DQ346ZBGM2V5PDUP3SDQBOJANCNFSM4QQYKBCA.

abettermap commented 4 years ago

Understood on audio. HTML wav media player looks easy, will try that.

Bring on the tileset! I won't get to those adjustments for a few hours but let me know when it's uploaded (i think only thing it will make temporarily screwy are the ones that had http's in endo before the switch).

Made some progress w/the Details intro:

image

However, as much as I like the flags, I feel like they're competing with the beautiful endonym heading above them. SO how about this instead?

image

abettermap commented 4 years ago

Wow it only took like 8 minutes to make the audio work. Thanks HTML5!

I pushed that along w/the second of the two intro screenshots, should be ready shortly: https://deploy-preview-68--languagemapping.netlify.app/

What else is left (besides adapting to the new schema) and making +4 more neighbs clickable/displayed? Or maybe I should just show them in full to be consistent w/the countries?

abettermap commented 4 years ago

oops sorry deploy is https://deploy-preview-69--languagemapping.netlify.app/

abettermap commented 4 years ago

the full neighbs look totally fine actually:

image

thoughts?

abettermap commented 4 years ago

sorry don't kill me but can we change Font URL to Font Image Alt? It won't get mistaken for a font that way.

One other thing, and I know I've given mixed instr's on this, but this is a proper dropbox URL:

https://www.dropbox.com/s/vhwi767ez3jdvnd/Avestan.svg?raw=1

Currently I am correcting the URLs manually in the code, but if you can switch them over to this format then I won't have to. The key pieces are:

  1. https://www.dropbox.com
  2. ?raw=1

And you can (and should) always confirm when you enter it into the data that it's working by visiting it directly in the browser. For example, https://www.dropbox.com/s/vhwi767ez3jdvnd/Avestan.svg?raw=1 should yield the image:

image

If it opens up a dialog to download/save the file, then the format is incorrect.

Hope that's doable, let me know if questions/concerns.

rperlin-ela commented 4 years ago

Agreed on flags, no need, countries in italics is good.

If additional neighborhoods seem to fit, that’s great.

Can’t seem to play the audio yet — for Mandaic, I just see this. And I think for audio maybe full-screen is overkill?

On Aug 31, 2020, at 5:35 PM, Jason Lampel notifications@github.com wrote:

Wow it only took like 8 minutes to make the audio work. Thanks HTML5!

I pushed that along w/the second of the two intro screenshots, should be ready shortly: https://deploy-preview-68--languagemapping.netlify.app/ https://deploy-preview-68--languagemapping.netlify.app/ What else is left (besides adapting to the new schema) and making +4 more neighbs clickable/displayed? Or maybe I should just show them in full to be consistent w/the countries?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/68#issuecomment-684054477, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5C3ZQPY4FNFK43K4VTSDQJS5ANCNFSM4QQYKBCA.

rperlin-ela commented 4 years ago

No sooner said than I reloaded and it’s playing!

On Aug 31, 2020, at 6:23 PM, Ross Perlin perlin@elalliance.org wrote:

Agreed on flags, no need, countries in italics is good.

If additional neighborhoods seem to fit, that’s great.

Can’t seem to play the audio yet — for Mandaic, I just see this. And I think for audio maybe full-screen is overkill?

<Screen Shot 2020-08-31 at 6.21.45 PM (2).png>

On Aug 31, 2020, at 5:35 PM, Jason Lampel <notifications@github.com mailto:notifications@github.com> wrote:

Wow it only took like 8 minutes to make the audio work. Thanks HTML5!

I pushed that along w/the second of the two intro screenshots, should be ready shortly: https://deploy-preview-68--languagemapping.netlify.app/ https://deploy-preview-68--languagemapping.netlify.app/ What else is left (besides adapting to the new schema) and making +4 more neighbs clickable/displayed? Or maybe I should just show them in full to be consistent w/the countries?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/68#issuecomment-684054477, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5C3ZQPY4FNFK43K4VTSDQJS5ANCNFSM4QQYKBCA.

rperlin-ela commented 4 years ago

No prob, column name and Dropbox links both changed.

On Aug 31, 2020, at 6:00 PM, Jason Lampel notifications@github.com wrote:

sorry don't kill me but can we change Font URL to Font Image Alt? It won't get mistaken for a font that way.

One other thing, and I know I've given mixed instr's on this, but this is a proper dropbox URL:

https://www.dropbox.com/s/vhwi767ez3jdvnd/Avestan.svg?raw=1

Currently I am correcting the URLs manually in the code, but if you can switch them over to this format then I won't have to. The key pieces are:

https://www.dropbox.com ?raw=1 And you can (and should) always confirm when you enter it into the data that it's working by visiting it directly in the browser. For example, https://www.dropbox.com/s/vhwi767ez3jdvnd/Avestan.svg?raw=1 https://www.dropbox.com/s/vhwi767ez3jdvnd/Avestan.svg?raw=1 should yield the image:

https://user-images.githubusercontent.com/4974087/91772814-d50f4b00-eba2-11ea-8aeb-7028e2fdf0c0.png If it opens up a dialog to download/save the file, then the format is incorrect.

Hope that's doable, let me know if questions/concerns.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/68#issuecomment-684064931, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5DW2WA5GVQFDKQVSSTSDQMQLANCNFSM4QQYKBCA.

abettermap commented 4 years ago

Yeah full screen overkill for audio, it was just easiest and I was expecting SoundCloud embed size.

Can it at least stay in a dialog, just not full screen? Don’t really know where else to put it.

rperlin-ela commented 4 years ago

Dialog seems fine, just want to keep it reasonably proportioned, maybe even nice if people still see some map.

On Aug 31, 2020, at 6:30 PM, Jason Lampel notifications@github.com wrote:

Yeah full screen overkill for audio, it was just easiest and I was expecting SoundCloud embed size.

Can it at least stay in a dialog, just not full screen? Don’t really know where else to put it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/68#issuecomment-684076563, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5EU5X7OQPGQRJQ5PWLSDQQARANCNFSM4QQYKBCA.

abettermap commented 4 years ago

No problem, can do.

Thanks for changing dropbox, etc.!

Re: full neighbs, here is longest and it still allows the first Description line to peek through on mobile:

image

and the two-liners even more so with a bit of non-first-letter Descrip text showing:

image

I can snug up the vertical padding a little more too, but it's looking pretty comfortably proportionate as-is.

Roll with it?

abettermap commented 4 years ago

I have an important commitment for the next few hours so just holler on the full-neighb decisions and let me know when you've got the freshie dataset uploaded.

rperlin-ela commented 4 years ago

Looks good!

On Aug 31, 2020, at 6:42 PM, Jason Lampel notifications@github.com wrote:

No problem, can do.

Thanks for changing dropbox, etc.!

Re: full neighbs, here is longest and it still allows the first Description line to peek through on mobile:

https://user-images.githubusercontent.com/4974087/91775556-93819e80-eba8-11ea-9577-7316dddbf05e.png and the two-liners even more so with a bit of non-first-letter Descrip text showing:

https://user-images.githubusercontent.com/4974087/91775626-c1ff7980-eba8-11ea-9df4-8a728fe0026d.png I can snug up the vertical padding a little more too, but it's looking pretty comfortably proportionate as-is.

Roll with it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/68#issuecomment-684080485, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5HERGVI3OXNJHMAQULSDQRL7ANCNFSM4QQYKBCA.

rperlin-ela commented 4 years ago

I think Details is really solid as is and fine to go with full-neighb. There may be other things people see or think of, but right now it’s not over-stuffed, which I like.

Related question: will the +1, +2 etc in the pop-ups still be clickable? Maybe this relates to the larger question of what should be clickable.

New tileset is coming shortly before I hit the hay in an hour or two. I’ll probably do tileset switcharoo again soon, but this is hopefully the big one, including schema changes, just about every description, SVG links (hopefully), and various other tweaks.

For the SVGs, is it terrible if I basically use up-close, cropped screenshots from our own UI (with dark background) — and then convert to SVG? A little ridiculous, I realize, but that’s looking like the most streamlined, surefire way. I can also do something similar from other sites, but don’t think there are high-quality images for most lying around.

On Aug 31, 2020, at 6:44 PM, Jason Lampel notifications@github.com wrote:

I have an important commitment for the next few hours so just holler on the full-neighb decisions and let me know when you've got the freshie dataset uploaded.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/68#issuecomment-684081160, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5BNCLDRMV4HIXFN73DSDQRTVANCNFSM4QQYKBCA.

rperlin-ela commented 4 years ago

Ok, new tileset is in there

On Aug 31, 2020, at 9:56 PM, Ross Perlin perlin@elalliance.org wrote:

I think Details is really solid as is and fine to go with full-neighb. There may be other things people see or think of, but right now it’s not over-stuffed, which I like.

Related question: will the +1, +2 etc in the pop-ups still be clickable? Maybe this relates to the larger question of what should be clickable.

New tileset is coming shortly before I hit the hay in an hour or two. I’ll probably do tileset switcharoo again soon, but this is hopefully the big one, including schema changes, just about every description, SVG links (hopefully), and various other tweaks.

For the SVGs, is it terrible if I basically use up-close, cropped screenshots from our own UI (with dark background) — and then convert to SVG? A little ridiculous, I realize, but that’s looking like the most streamlined, surefire way. I can also do something similar from other sites, but don’t think there are high-quality images for most lying around.

On Aug 31, 2020, at 6:44 PM, Jason Lampel <notifications@github.com mailto:notifications@github.com> wrote:

I have an important commitment for the next few hours so just holler on the full-neighb decisions and let me know when you've got the freshie dataset uploaded.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/68#issuecomment-684081160, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5BNCLDRMV4HIXFN73DSDQRTVANCNFSM4QQYKBCA.

abettermap commented 4 years ago

I think Details is really solid as is and fine to go with full-neighb. There may be other things people see or think of, but right now it’s not over-stuffed, which I like.

Agreed! Will slim down vertical padding slightly, on mobile at least, but that's probably it.

Related question: will the +1, +2 etc in the pop-ups still be clickable? Maybe this relates to the larger question of what should be clickable.

Hmm, up to you but I don't feel that's necessary as it's already redundant with the Details. I'd say either leave as-is, show the full in the popups like we are in Details, or do a ... when it's too long. Personally I think fine as-is since it's shown in full in the Details, and it serves its purpose in life as just a lil summary popup.

I’ll probably do tileset switcharoo again soon, but this is hopefully the big one, including schema changes, just about every description, SVG links (hopefully), and various other tweaks.

Awesome, will take a look tomorrow. Just got done w/personal stuff.

For the SVGs, is it terrible if I basically use up-close, cropped screenshots from our own UI (with dark background) — and then convert to SVG

Yes, don't do that! If that's last resort then just get a PNG instead. Screenshot makes it a "raster" image (grid/pixel-based), which defeats purpose of SVG ("vector", coordinate-based, infinitely scaleable).

Check it out though, I got Coptic to show on Mac Firefox simply by installing the Noto Coptic on my computer:

image

What a badass font!

This makes me wonder... what would happen if I just loaded all the fonts in the browser? Would it show them all?

Stay tuned...

abettermap commented 4 years ago

Uhhhhh

Did I make all the tofu not a thing? I just straight-up added 13 fonts, set them ALL as the body and heading fonts, and... no more tofu.

I've tested in FF, Chrome on Mac, Chrome on iOS, and Chrome on my gf's Windows. No tofu to be found with any of the usual suspects.

It doesn't any sense to me why this works, but it sure seems to. Based on what I did, I would have expected it to try and render everything in the page as custom fonts, not just the spots with those special characters.

Anyway, more deets in PR but WOW if that's the case! Just don't tell the performance police that I'm loading all those fonts, or the users with skimpy data plans for that matter 😆

rperlin-ela commented 4 years ago

Wow, this would be amazing— I’m tied up with a few meetings now but will upload a new tileset and test shortly after noon EST

On Sep 1, 2020, at 2:22 AM, Jason Lampel notifications@github.com wrote:

Uhhhhh

Did I make all the tofu not a thing? I just straight-up added 13 fonts, set them ALL as the body and heading fonts, and... no more tofu.

I've tested in FF, Chrome on Mac, Chrome on iOS, and Chrome on my gf's Windows. No tofu to be found with any of the usual suspects.

It doesn't any sense to me why this works, but it sure seems to. Based on what I did, I would have expected it to try and render everything in the page as custom fonts, not just the spots with those special characters.

Anyway, more deets in PR but WOW if that's the case! Just don't tell the performance police that I'm loading all those fonts, or the users with skimpy data plans for that matter 😆

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

abettermap commented 4 years ago

Sounds good. I’m going to jump into Boundaries today once the fonts and Details are final.

You’re still going to correct some of those YouTube URLs right?

rperlin-ela commented 4 years ago

Fresh tileset just in there, with corrected Youtube URLs. I tested the font thing (Zuwara) and I think you did it and I think it’s well worth it. Still good to keep non-ASL/Avestan/Mongolian ones in the Font Image Alt column? (Most are not true SVGs either way, thanks for explaining that, and I’m not totally sure how I’d source them, so your solution comes in the nick of time)

I’ve got to do some serious QC’ing related to points that are very close together, still trying to get the hang of adjusting the coordinates, but I think things otherwise are coming together.

On Sep 1, 2020, at 10:28 AM, Jason Lampel notifications@github.com wrote:

Sounds good. I’m going to jump into Boundaries today once the fonts and Details are final.

You’re still going to correct some of those YouTube URLs right?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/68#issuecomment-684895979, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5F4BNACC42L4CKKFUTSDUAKTANCNFSM4QQYKBCA.

abettermap commented 4 years ago

I tested the font thing (Zuwara) and I think you did it and I think it’s well worth it.

Awesome, glad we may have a solution! Just make sure to:

1. Back up ("Name current version")

image

...just in case we're wrong about the next step. Would hate for you to lose those SVG URLs if we do need them!

2. Clear all values in Font Image Alt

...except for Mongolian, ASL, and Avestan. I am basing the code logic on the existence of those values, so if you remove them then it will use the font (like you saw with Zuwara). I may not have explained well last night so let me know!

Other replies

Still good to keep non-ASL/Avestan/Mongolian ones in the Font Image Alt column?

Yes indeed. This makes more sense to me data-wise, even if it's only a handful of records, as it's cleaner and more intuitive to check for in the code. While relying on Endonym column for image stuff technically worked, it had a bad code-smell to it!

Re: Avestan, is that one just not available as a Noto?

Re: SVG it's ok if you ever can't find this format. It's just infinitely scaleable and clean, but a good PNG is fine too.

I’ve got to do some serious QC’ing related to points that are very close together, still trying to get the hang of adjusting the coordinates

Yeah I'm not great at that either. My advice would be to zoom into the area in question in MB Studio and watch the coordinates in the URL change to get a feel for the relationship between pixels and coordinates/zoom.

Google Maps also has a Measure Distance tool if that helps (right-click the map):

image

rperlin-ela commented 4 years ago

Great, thanks for this. All backed up and now clearing URLs out of the Font Image Alt column for everything but ASL/Avestan/Mongolian, if I’ve got this right.

There is Noto Avestan, and I can load it into MB in case I can ever find or figure out how to type the endonym (that’s the hold-up) in the script!

Hopefully all good and on to Boundaries!

On Sep 1, 2020, at 1:53 PM, Jason Lampel notifications@github.com wrote:

I tested the font thing (Zuwara) and I think you did it and I think it’s well worth it.

Awesome, glad we may have a solution! Just make sure to:

  1. Back up ("Name current version")

    https://user-images.githubusercontent.com/4974087/91888150-0a6e7400-ec49-11ea-9dc9-14325650972d.png ...just in case we're wrong about the next step. Would hate for you to lose those SVG URLs if we do need them!

  2. Clear all values in Font Image Alt

...except for Mongolian, ASL, and Avestan. I am basing the code logic on the existence of those values, so if you remove them then it will use the font (like you saw with Zuwara). I may not have explained well last night so let me know!

Other replies

Still good to keep non-ASL/Avestan/Mongolian ones in the Font Image Alt column?

Yes indeed. This makes more sense to me data-wise, even if it's only a handful of records, as it's cleaner and more intuitive to check for in the code. While relying on Endonym column for image stuff technically worked, it had a bad code-smell to it!

Re: Avestan, is that one just not available as a Noto?

Re: SVG it's ok if you ever can't find this format. It's just infinitely scaleable and clean, but a good PNG is fine too.

I’ve got to do some serious QC’ing related to points that are very close together, still trying to get the hang of adjusting the coordinates

Yeah I'm not great at that either. My advice would be to zoom into the area in question in MB Studio and watch the coordinates in the URL change to get a feel for the relationship between pixels and coordinates/zoom.

Google Maps also has a Measure Distance tool if that helps (right-click the map):

https://user-images.githubusercontent.com/4974087/91888430-89fc4300-ec49-11ea-845a-8e7bf260e3bc.png — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/68#issuecomment-685031786, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5FZI5BRPBFOE2IW57DSDUYJLANCNFSM4QQYKBCA.

abettermap commented 4 years ago

Great, thanks for this. All backed up and now clearing URLs out of the Font Image Alt column for everything but ASL/Avestan/Mongolian, if I’ve got this right.

Yes, did you replace the tileset though? I'm still seeing images, not fonts.

rperlin-ela commented 4 years ago

Not yet, will do shortly

On Sep 1, 2020, at 2:14 PM, Jason Lampel notifications@github.com wrote:

Great, thanks for this. All backed up and now clearing URLs out of the Font Image Alt column for everything but ASL/Avestan/Mongolian, if I’ve got this right.

Yes, did you replace the tileset though? I'm still seeing images, not fonts.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/68#issuecomment-685045679, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5ATTAXDK2N7JCNKN4LSDU2Y7ANCNFSM4QQYKBCA.

abettermap commented 4 years ago

sweet let me know. here's tashelhyt in the deploy as a quick check once you've uploaded:

https://deploy-preview-69--languagemapping.netlify.app/details?id=865

will merge once confirmed

abettermap commented 4 years ago

Quick question: can we drop this?

image

I restored it because I liked the wording, but it's kind of out of place now since there are no others of its kind. Not to mention the the section is pretty self-explanatory with the heading and dropdown labels:

image

On that same note, could we just drop the Options link on mobile as well? I've found it somewhat confusing (not a good sign considering I made it!) and not that useful. Seems fine to just start like this since the purdy legend is still peeking in the bottom and encouraging scrolling:

image

Thoughts?

rperlin-ela commented 4 years ago

Agreed and agreed

On Sep 1, 2020, at 2:46 PM, Jason Lampel notifications@github.com wrote:

Quick question: can we drop this?

https://user-images.githubusercontent.com/4974087/91892624-3c370900-ec50-11ea-8614-e35a4619f576.png I restored it because I liked the wording, but it's kind of out of place now since there are no others of its kind. Not to mention the the section is pretty self-explanatory with the heading and dropdown labels:

https://user-images.githubusercontent.com/4974087/91892790-7c968700-ec50-11ea-8974-f274d9ebd7fe.png On that same note, could we just drop the Options link on mobile as well? I've found it somewhat confusing (not a good sign considering I made it!) and not that useful. Seems fine to just start like this since the purdy legend is still peeking in the bottom and encouraging scrolling:

https://user-images.githubusercontent.com/4974087/91893181-f9c1fc00-ec50-11ea-88ec-fc3bf3761ac7.png Thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/68#issuecomment-685063380, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5BWAB3I36MGTMUWJK3SDU6PVANCNFSM4QQYKBCA.

rperlin-ela commented 4 years ago

Done, and Tashelhyt checks out, so good to merge

On Sep 1, 2020, at 2:19 PM, Jason Lampel notifications@github.com wrote:

sweet let me know. here's tashelhyt in the deploy as a quick check once you've uploaded:

https://deploy-preview-69--languagemapping.netlify.app/details?id=865 https://deploy-preview-69--languagemapping.netlify.app/details?id=865 will merge once confirmed

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/68#issuecomment-685048861, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5A5I3P7BA7HOTIYQHDSDU3LDANCNFSM4QQYKBCA.

abettermap commented 4 years ago

Nice!

One of my main concerns with all this is performance impacts since we're loading everything at once, and I definitely noticed the lag as a result.

However, I've found some tweaks to make the perceived load time substantially faster, but the trade-off is brief tofu for the custom ones like Tashelhyt, but it depends on what order I load them.

So, can you estimate based on this list, which ones are the most common in the dataset?

  Buginese,
  Chiki,
  Coptic,
  Limbu,
  MeeteiMayek,
  Myanmar,
  NKo,
  Sinhala,
  Sylhoti,
  SyriacEstrangela,
  Thaana,
  Tifinagh,
  Vai

The way I've set it up, it loads them alphabetically, so Tashelhyt shows temporary tofu because Tifinagh is way down at the end. Not a deal-breaker, but if you can give me that list back, in the top-to-bottom order of most-to-least-common, I will reorder the list.

abettermap commented 4 years ago

also i just found a way in Chrome Dev Tools to 100% confirm which font is being rendered. handy! here is syriac for example:

image

abettermap commented 4 years ago

i should also clarify that the "temporary tofu" is very brief and it doesn't happen again after the font has fully loaded

rperlin-ela commented 4 years ago

Nice, yeah, performance obviously key.

Here’s a rough most-to-least common list:

Myanmar Sinhala Sylhoti Nko Coptic Tifinagh Vai Limbu Syriac Meetei Thaana Buginese Chiki

On Sep 1, 2020, at 3:45 PM, Jason Lampel notifications@github.com wrote:

i should also clarify that the "temporary tofu" is very brief and it doesn't happen again after the font has fully loaded

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Language-Mapping/language-map/issues/68#issuecomment-685092820, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNKB5FTSLNI6RH3ZEOM4JTSDVFODANCNFSM4QQYKBCA.

rperlin-ela commented 4 years ago

Small things but maybe the filtery icon no longer makes the most sense for Explore (something more search-y?) and maybe we shouldn’t use the same icon for both the Details panel and for Data Table & Filters? (There’s always the bulleted list we’re already using next to the word Data.) Within the Data table, still a little crowded in the upper right, I still get confused between the “x” that closes the table and the one that clears the filters— which maybe should echo “Clear selected”? Sorry if I’m jumping the gun, just while I think of it...

On Sep 1, 2020, at 3:56 PM, Ross Perlin perlin@elalliance.org wrote:

Nice, yeah, performance obviously key.

Here’s a rough most-to-least common list:

Myanmar Sinhala Sylhoti Nko Coptic Tifinagh Vai Limbu Syriac Meetei Thaana Buginese Chiki

On Sep 1, 2020, at 3:45 PM, Jason Lampel notifications@github.com wrote:

i should also clarify that the "temporary tofu" is very brief and it doesn't happen again after the font has fully loaded

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

abettermap commented 4 years ago

Here’s a rough most-to-least common list:

cool, made the switch, hopefully noticeable. not pushed yet.

interesting how some of these the browser/system just "knows" what to use. Sherpa on Mac for example:

image

Small things but maybe the filtery icon no longer makes the most sense for Explore (something more search-y?) and maybe we shouldn’t use the same icon for both the Details panel and for Data Table & Filters? (There’s always the bulleted list we’re already using next to the word Data.)

agreed on all that, been meaning to mention the Explore. can you find me some winners? FYI the search on that site is not super accurate. i have better luck going to the individual pages like Ionicons or whatever, then doing a "Find" in the page.

Within the Data table, still a little crowded in the upper right, I still get confused between the “x” that closes the table and the one that clears the filters— which maybe should echo “Clear selected”? Sorry if I’m jumping the gun, just while I think of it...

Yeah the whole top part of the table sucks, among other things in the table. Haven't touched any of it yet, been saving the worst for last. Wanted to get into boundaries sooner but font stuff! Worth it though.

abettermap commented 4 years ago

So in tandem with the hopefully-faster setup, I came across a way to get all the Endo fonts into the UI (except for NKo) without storing them in the repo: https://fonts.google.com/earlyaccess

Will push in a few so you can test but I think it's working splendidly.

rperlin-ela commented 4 years ago

Excellent.

Sounds good about icons and such. Somehow not very inspired at the moment, but for Explore, probably IMSearch would do the trick. IMLocation looks good if you need something to replace the asterisk next to local items in the table. For Data Table & Filter, I’d probably use that same three-bullet list you have next to Data. And for turning off the filter, how about RIFilterOffFill?

On Sep 1, 2020, at 5:27 PM, Jason Lampel notifications@github.com wrote:

 So in tandem with the hopefully-faster setup, I came across a way to get all the Endo fonts into the UI (except for NKo) without storing them in the repo: https://fonts.google.com/earlyaccess

Will push in a few so you can test but I think it's working splendidly.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

abettermap commented 4 years ago

Thanks, changed the ImSearch and I've made some notes about the table suggestions but not going in this branch.

FYI: https://deploy-preview-69--languagemapping.netlify.app/details?id=409 video:

image

abettermap commented 4 years ago

I pushed up changes, tested Tash and Coptic, all seem good! Changes to panels added as well. Details in commit messages:

Merging PR!

abettermap commented 4 years ago

closed by #69

abettermap commented 4 years ago

shoot i completely for about sharing. that was the whole point of setting up the routing. e.g. don't want to tell people 10 steps to get to Batta, just want them to go to it.

@rperlin-ela any opposition if i add a "Share" link and icon to the right of "Audio"? on click it would open a small popover with the same buttons as these:

image

except instead of the project URL it would obviously be the unique, specific one of the current community. would look like this:

image

abettermap commented 4 years ago

also i dropped the Description perceived font weight to normal but left the headings same. much easier to read!

image

rperlin-ela commented 4 years ago

Great call, I think I still need to work on the general sharing text: is there a good way to automate the snippet of text that will be shared from each community?

On Sep 1, 2020, at 10:12 PM, Jason Lampel notifications@github.com wrote:  also i dropped the Description perceived font weight to normal but left the headings same. much easier to read!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

abettermap commented 4 years ago

Yeah I think it’s doable on my end. Would probably just use the Language name plus “ —- NYC Language Map” or something as the post title (or email subject) and then for social media maybe a truncated version of Description with an ellipsis at the end. Could probably show the full in email body.

That work?