Language-Research-Technology / crate-o

Crate-O is a browser-based editor for Research Object Crates (RO-Crate)
https://language-research-technology.github.io/crate-o/
GNU General Public License v3.0
6 stars 2 forks source link

Make sure pcdm hasMember and memberOf have the correct PCDM based URIs and are in the Structure input group #121

Closed ptsefton closed 5 months ago

otili9890 commented 6 months ago

I kept the https://schema.org/memberOf reference as it exists but http://schema.org/conformsTo does not exist anywhere. Not sure what to replace it with. For the following invalid locations I replaced them with their location in pcdm. https://schema.org/hasMember does not exist, changed to pcdm https://schema.org/fileOf does not exist, changed to pcdm https://schema.org/hasFile does not exist, changed to pcdm

ptsefton commented 6 months ago

No you need to change the memberOf one as well to pcdm

--

From: otili9890 @.> Date: Friday, 19 April 2024 at 11:08 am To: Language-Research-Technology/crate-o @.> Cc: Peter Sefton @.>, Author @.> Subject: Re: [Language-Research-Technology/crate-o] Make sure pcdm hasMember and memberOf have the correct PCDM based URIs and are in the Structure input group (Issue #121)

I kept the https://schema.org/memberOf reference as it exists but http://schema.org/conformsTo does not exist anywhere. Not sure what to replace it with. For the following invalid locations I replaced them with their location in pcdm. https://schema.org/hasMember does not exist, changed to pcdm https://schema.org/fileOf does not exist, changed to pcdm https://schema.org/hasFile does not exist, changed to pcdm

— Reply to this email directly, view it on GitHubhttps://github.com/Language-Research-Technology/crate-o/issues/121#issuecomment-2065566843, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAFYTWHPJ5LRFSAGXZSKQRDY6BU7PAVCNFSM6AAAAABGMQSRCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRVGU3DMOBUGM. You are receiving this because you authored the thread.Message ID: @.***>

rosanna-smith commented 5 months ago

Merge waiting on some descriptions in this issue: https://github.com/Language-Research-Technology/crate-o/issues/114 @ptsefton

otili9890 commented 5 months ago

This can be closed after the completion of #114