search

Language-Research-Technology / oni-ui

Oni Discovery Portal using Oni REST API
GNU General Public License v3.0
0 stars 3 forks source link

Remove View and Download File buttons for restricted access items #31

Open rosanna-smith opened 1 year ago

rosanna-smith commented 1 year ago

This depends on: https://github.com/Language-Research-Technology/oni/issues/2

For objects where access is restricted, the View File and Download File buttons are redundant and could be confusing. Better to just show the red permission message there. On restricted audio files (and I assume video as well) the permission message doesn't appear because Preview File is there but changes to that if you try to click it.

Example: https://data-uat.ldaca.edu.au/object?id=arcp%3A%2F%2Fname%2Cfarms-to-freeways-example-dataset%2Finterview-object%2Fpatriciacolless&_crateId=arcp%3A%2F%2Fname%2Cfarms-to-freeways-example-dataset

rosanna-smith commented 12 months ago

Looks great for text docs like csv, pdf etc! On mp3 and video it still shows preview file and if you click that then the red message appears, though it's good that the view and download options don't appear.

moisbo commented 12 months ago

No worries. I would need to put this off because I would need to change the api to give me a 403 without downloading it

moisbo commented 7 months ago

Not sure if related but some files only appear the Download button when after getting a Preview