Language-Research-Technology / oni

new Oni implementation
GNU General Public License v3.0
1 stars 3 forks source link

BUG: URL and nextyurr are wrong in results returned by data.ldaca.edu.au API (missing domain - has https instead) #16

Open ptsefton opened 2 months ago

ptsefton commented 2 months ago

{ "crateId": "arcp://name,doi10.25949%2F24769173.v1/W2C", "license": "https://creativecommons.org/licenses/by/4.0/", "name": "ICE: W2C: Published news reports", "description": "Published news reports from the International Corpus of English (Aus)", "objectRoot": "/opt/storage/oni/ocfl/arcp_name_doi10.25949%2F24769173.v1/W2C/object", "locked": false, "createdAt": "2024-06-06T05:34:24.495Z", "updatedAt": "2024-06-06T05:34:24.495Z", "recordType": [ "Dataset", "RepositoryCollection" ], "memberOf": [ "arcp://name,doi10.25949%2F24769173.v1" ], "conformsTo": "https://w3id.org/ldac/profile#Collection", "record": { "name": "ICE: W2C: Published news reports", "license": "https://creativecommons.org/licenses/by/4.0/", "description": "Published news reports from the International Corpus of English (Aus)" }, "url": "https://https/api/object/arcp%3A%2F%2Fname%2Cdoi10.25949%252F24769173.v1%2FW2C?meta" } ], "nextUrl": "https://https/api/object?conformsTo=https%3A%2F%2Fw3id.org%2Fldac%2Fprofile%23Collection&offset=10" }

h-croser commented 1 month ago

I've noticed a similar and possibly related issue. Some id attributes that are URLs have an additional 'https://' at the start and an additional '/api' in the middle. Below the id should be https://data.ldaca.edu.au/api/object/arcp%3A%2F%2Fname%2Cdoi10.26180%252F23961609/%233-COOEE-4.doc but is instead https://https://data.ldaca.edu.au/api/api/object/arcp%3A%2F%2Fname%2Cdoi10.26180%252F23961609/%233-COOEE-4.doc

{
    "@id": "https://https://data.ldaca.edu.au/api/api/object/arcp%3A%2F%2Fname%2Cdoi10.26180%252F23961609/%233-COOEE-4.doc",
    "@type": "File",
    "name": "A COrpus of Oz Early English (COOEE)",
    "dateModified": "2021-11-10T11:16:31+11:00",
    "description": "Describes the collection methodology and sources",
    "encodingFormat": [
        "application/msword",
        {
            "@id": "https://www.nationalarchives.gov.uk/PRONOM/fmt/40"
        }
    ]
}
moisbo commented 1 month ago

Hi Hamish -- thank you for the report. Can you try now please?

h-croser commented 1 month ago

Looking at a couple of collections (COOEE and Austlit) it looks like it's fixed. I wasn't expecting such a fast response. Thanks!