search

Language-Research-Technology / ro-crate-modes

RoCrate Editor Profiles
0 stars 1 forks source link

Duplicate sections in language-data-commons-collection-profile.json #14

Open rosanna-smith opened 8 months ago

rosanna-smith commented 8 months ago

These sections have the same id, name, help text, etc. Should one of them be removed or are both needed?

hasCollectionProtocol:

https://github.com/Language-Research-Technology/ro-crate-editor-profiles/blob/ab03b70a529afdad1d33258531d6d1dd2b54ec95/profiles/language-data-commons-collection-profile.json#L174C17-L174C17

https://github.com/Language-Research-Technology/ro-crate-editor-profiles/blob/ab03b70a529afdad1d33258531d6d1dd2b54ec95/profiles/language-data-commons-collection-profile.json#L298

citation:

https://github.com/Language-Research-Technology/ro-crate-editor-profiles/blob/ab03b70a529afdad1d33258531d6d1dd2b54ec95/profiles/language-data-commons-collection-profile.json#L136C36-L136C44

https://github.com/Language-Research-Technology/ro-crate-editor-profiles/blob/ab03b70a529afdad1d33258531d6d1dd2b54ec95/profiles/language-data-commons-collection-profile.json#L270C9-L270C9

author:

https://github.com/Language-Research-Technology/ro-crate-editor-profiles/blob/ab03b70a529afdad1d33258531d6d1dd2b54ec95/profiles/language-data-commons-collection-profile.json#L106C14-L106C14

https://github.com/Language-Research-Technology/ro-crate-editor-profiles/blob/ab03b70a529afdad1d33258531d6d1dd2b54ec95/profiles/language-data-commons-collection-profile.json#L427

rosanna-smith commented 8 months ago

There are also two metadata fields under CollectionProtocol called "description" but they have different help text (lines 419 and 439). I'm not sure if those are intended for different sections and if not, if one overrides the other.