LanguageMachines / PICCL

A set of workflows for corpus building through OCR, post-correction and normalisation
Other
48 stars 6 forks source link

Conduct extensive tests of the latest release (v0.7) #43

Closed proycon closed 4 years ago

proycon commented 6 years ago

You might want to repeat the following items for multiple languages, and with/without post-processing options such as tokenisation (ucto) and linguistic enrichment (Frog). You may also want to test both from the interface as well as from the command line:

In testing all of the above, consider a) whether it runs (i.e. no crashes) and b) whether results are actually sensible/correct.

For most of these scenarios, an integration test for the backend is already available in test.sh, and those tests are only limited to aspect (a). There are no tests that invoke the front-end and wrapper. Please suggest (small) data and improvements for further automated tests where applicable.

Regarding the webservice-end of things:

Regarding software dependencies:

Please always report problems or feature requests in separate new issues (not in this thread), but do confirm things that are working properly here (just tick the boxes) so we have verification. Ideally, wherever they can't be automated yet, these tests should be repeated when a major release update occurs.

JessedeDoes commented 5 years ago

Can we test the latest version in the Nijmegen web service?

proycon commented 5 years ago

It's still one release behind, but I can update it later today/tomorrow.

JessedeDoes commented 5 years ago

Thanks!

proycon commented 5 years ago

The latest release has been deployed in Nijmegen.

JessedeDoes commented 5 years ago

I still get errors on plain text with ticcl disabled:

error.log

Is this related to the fact that uploaded plain text is listed as "PDFFormat" in the uploaded documents list?

image

proycon commented 5 years ago

Hmm, that is quite wrong indeed (but probably not the cause of the error). I'll look into it and run a test myself.

proycon commented 5 years ago

I finally fixed this persistent problem (meaning I actually tested it now as things kept popping up). It's in the latest master branch (so not released/deployed yet). I'll do some extra tests prior to release to see if I didn't break anything obvious in the process. Still, elaborate testing by @martinreynaert as proposed in this issue remains very relevant!

The wrapper script has become somewhat convoluted as what we ideally need but don't have is automatic workflow discovery, considering the complexity grows. I did some cleanup and renaming to at least make things clearer.

A problem here is also that the wrapper script currently is not covered by the CI tests (as those only tests the nextflow workflows directly rather than the full integration and webservice overhead).

proycon commented 5 years ago

v0.7.6 is released and deployed now.

proycon commented 4 years ago

This is not gonna happen anymore I guess, v0.9.0 has been released now, expiring this issue...