br should inherit from AbstractMarkupElement as well

LanguageMachines / libfolia

FoLiA library for C++

https://proycon.github.io/folia

GNU General Public License v3.0

15 stars 7 forks source link

br should inherit from AbstractMarkupElement as well #14

Closed proycon closed 7 years ago

proycon commented 7 years ago

br is both structure annotation and markup annotation, but right now folialint fails on the xlink:href attribute:

unsupported attribute: href='http://resources.huygens.knaw.nl/retroapp/service_declercq/13/images/0180.tiff' for node with tag 'br'

kosloot commented 7 years ago

Multiple inheritage is impossible, because both AbstractTextMarkup and AbstractStructureElement have a static PROPS memer as well as a number of the same functions. Changing this is VERY difficult, and will lead to convoluted code. Just setting AbstractactTextMarkup.PROPS.XLINK to true is far more easy.