search

LanguageMachines / libfolia

FoLiA library for C++
https://proycon.github.io/folia
GNU General Public License v3.0
15 stars 7 forks source link

generate id fails when parent doesn't hava an id #19

Closed kosloot closed 7 years ago

kosloot commented 7 years ago

When adding a word to a sentence without an ID, (for instance in ucto) you get a failure: "Unable to generate an id from ID= "

Generate_id should look 'upwards' for parent withe an id. With as final resort the document id

kosloot commented 7 years ago

Ok, this is in fact taken care off in libfolia. But the problem arises for nodes that don't have a parent yet. For instance when ucto wants to add a new word. libfolia cannot look for the parent then, and hopes for a hint from ucto. which fails to provide one. This can be fixed in ucto for now. But there is a fundamental problem I think: Without a 'generate_id' hint, append should honor the AUTO_GENERATE_ID property, but that seems to be unimplemented!?!?

kosloot commented 7 years ago

OK, AUTO_GENERATE_ID is now implemented again.