search

LanguageMachines / libfolia

FoLiA library for C++
https://proycon.github.io/folia
GNU General Public License v3.0
15 stars 7 forks source link

refactoring idea 3 #41

Closed kosloot closed 3 years ago

kosloot commented 4 years ago

folia_engine has al lot of functions with a depth parameter. This could probably also be part of the Engine Class as an internal property.

kosloot commented 4 years ago

There is already a _last_depth property. need to look into it....

kosloot commented 3 years ago

No. The depth parameter is important. It signals the position to attach new nodes. That can be at the current _last_depth but also deeper or higher-up. AFTER such an attachment _last_depth is updated to the new depth. To make this more clear, the parameter depth is renamed to new_depth. Closing this issue/