LaniJ / invoice-dragon

Open source application for creating free invoices and receipts
https://invoicedragon.com/
MIT License
691 stars 51 forks source link

Added French, Dutch, German, Spanish, and Portuguese translation. #9

Closed Davidthecode closed 10 months ago

Davidthecode commented 11 months ago

I added French, Dutch, German, Spanish, and Portuguese translation. so it is available in all 5 languages. The overall structure does not change. the only change i made to the UI was to add a select dropdown in the homepage where a user can select any of the 5 languages to continue with. i implemented it with next-translate package.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
invoice-receipt-generator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 10:17pm
Davidthecode commented 11 months ago

This pr helps with the issue #3

kenzivoy commented 11 months ago

looks great

LaniJ commented 11 months ago

For the language dropdown, could it be moved to the top right corner? Then, we wouldn't need the "language" label, it would just be a dropdown with the language abbreviations. E.g - EN for English

Screenshot 2023-08-06 at 11 22 22
RoneoOrg commented 11 months ago

Glad to see that translations are coming. Feel free to ping me if the French translation requires a review

Davidthecode commented 11 months ago

Hi @LaniJ, i have made all the changes

LaniJ commented 10 months ago

Nicely done. Only thing i notice is the the dropdown doesn't persist the displayed selection when the page is changed. The selected language is still correct but the dropdown value shows 'en' by default. Could you pick the value from local storage instead? Everything else looks good to me. 😊

Davidthecode commented 10 months ago

oh my bad, i have fixed that @LaniJ

Davidthecode commented 10 months ago

Hi @LaniJ, I'm waiting on your feedback

LaniJ commented 10 months ago

Hiya @Davidthecode Looks good. thanks for contributing! 😊

Davidthecode commented 10 months ago

🚀🚀