Closed Davidthecode closed 10 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
invoice-receipt-generator | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 15, 2023 10:17pm |
This pr helps with the issue #3
looks great
For the language dropdown, could it be moved to the top right corner? Then, we wouldn't need the "language" label, it would just be a dropdown with the language abbreviations. E.g - EN for English
Glad to see that translations are coming. Feel free to ping me if the French translation requires a review
Hi @LaniJ, i have made all the changes
Nicely done. Only thing i notice is the the dropdown doesn't persist the displayed selection when the page is changed. The selected language is still correct but the dropdown value shows 'en' by default. Could you pick the value from local storage instead? Everything else looks good to me. 😊
oh my bad, i have fixed that @LaniJ
Hi @LaniJ, I'm waiting on your feedback
Hiya @Davidthecode Looks good. thanks for contributing! 😊
🚀🚀
I added French, Dutch, German, Spanish, and Portuguese translation. so it is available in all 5 languages. The overall structure does not change. the only change i made to the UI was to add a select dropdown in the homepage where a user can select any of the 5 languages to continue with. i implemented it with next-translate package.