Lanrutcon / CatchTheWind

WoW AddOn - Cinematic Quest Interactions
19 stars 6 forks source link

Shift+click on rewards only works if you hold shift *before* you drag the mouse cursor over the reward. #17

Closed chevcast closed 8 years ago

chevcast commented 8 years ago

If you are already moused over a reward and showing the item's tooltip then pressing shift does nothing. I've been pressing F10 today when rewards pop up so I can compare stats to the gear I'm wearing. Then suddenly one time I saw the comparison tooltip but couldn't get it back so I stopped and messed with it for a bit.

Turns out you can show the comparison tooltip reliably if you hold SHIFT first and then drag the mouse over the reward. It will then show the item tooltip and the comparison tooltip. It just doesn't work if your mouse is already there and then you press SHIFT.

benoitheylens commented 8 years ago

I think to avoid mistakes you could maybe show the tooltip whenever you press shift and your mouse is on the reward (as it works in default UI. It's not very important but could lead new adopters to think there is a bug or a misconception instead of a nice feature ;).

chevcast commented 8 years ago

I don't think he intended this to work this way. I assume he would classify this behavior as a bug which is why I reported it here :)

chevcast commented 8 years ago

Now that I've been viewing tooltips properly I've been occasionally getting a positioning bug where the comparison tooltip appears off to the bottom right and this LUA error pops up:

Message: Interface\AddOns\CatchTheWind\Utils.lua:108: ShoppingTooltip2:SetPoint(): ShoppingTooltip1 is dependent on this
Time: 09/11/16 11:55:30
Count: 4
Stack: [C]: in function `SetPoint'
Interface\AddOns\CatchTheWind\Utils.lua:108: in function `CTW_GameTooltip_ShowCompareItem'
[string "*:OnEnter"]:12: in function <[string "*:OnEnter"]:1>

Locals: (*temporary) = ShoppingTooltip2 {
 0 = <userdata>
 updateTooltip = 0.2
 needsReset = true
}
(*temporary) = "TOPLEFT"
(*temporary) = ShoppingTooltip1 {
 0 = <userdata>
 updateTooltip = 0.2
 needsReset = true
}
(*temporary) = "TOPLEFT"
(*temporary) = 0
(*temporary) = 185.99110412598

This only happens sporadically. I had one reward window where the first reward showed the comparison tooltip just fine but the second one to the right of it would show this error each time.

chevcast commented 8 years ago

Video of tooltip bug.

https://youtu.be/jS-hkqZ5-ww

Lanrutcon commented 8 years ago

Thank you very much for the video. It's the best way to show what is happening to another person. Screenshots are also very good and in some causes are more than enough. Words can do the job, in most cases, but if the problem is too "complicated" then opt to take a screenshot or a video.

I'll see what's going tomorrow and I hope to release a new version (new stuff + bugfixes) in the next couple of days.

Thanks once again.

chevcast commented 8 years ago

np, I'm sure you'll see more from me as I continue to use it 😄

Super easy to do on Windows 10 too. The Xbox app has game DVR. When something happens I want to save I can press Windows Key + Alt + G and it will save a clip of the last minute of gameplay. You can then trim the clip right in the Xbox app and upload. It's useful for saving cool gaming moments but also works great for recording clips of bugs, especially those bugs you can't reproduce easily for a premeditated recording.

Lanrutcon commented 8 years ago

Thanks for the tip. I also use Xbox app to record my videos: good quality and the file size are pretty small - more than enough that . I didn't know about that shortcut, the "simple" Windows Key + Alt + R to start&stop record, but that one should come in handy in some situations.

Going back to the topic. This bug should be fixed in: https://github.com/Lanrutcon/CatchTheWind/commit/18e47d190f0a967307f764c209d08ef3e8f2adc1

Thanks for reporting.

chevcast commented 8 years ago

You can increase the video quality in settings if you want higher def.

Thanks for the fix!