search

LaosLaser / Firmware

Embedded software (firmware) for the laser system and components, including configuration files
27 stars 27 forks source link

Added support for Exhaust Enable output. #18

Closed TheGuv closed 10 years ago

TheGuv commented 10 years ago

The exhaust is turned on at the beginning of a job, and turns off when the job has completed after a configurable delay to purge remaining smoke. Useful for combining the output to drive air assist and exhaust together.

TheGuv commented 10 years ago

Guys, I haven't a clue what I'm doing with git so I apologise in advance if I'm doing this all wrong. These changes are tested and work fine here, but if something gets mangled by my poor git-fu and it doesn't work any more I'll fix i up after the merge. Somebody please send the git clue-bus.

pbrier commented 10 years ago

Looks all clean! I'll merge once I tested it here.

thinkl33t commented 10 years ago

Can this be merged?

TheGuv commented 10 years ago

Sure. It's been working great for me ever since. Maybe pbrier will get some time to do it soon.

jrv commented 10 years ago

Unfortunately, this pull request was made a long time ago and it cannot be merged automatically anymore. I'll see if I can merge it by hand.

jrv commented 10 years ago

I've added these changes to the latest version on Github. Can someone with exhaust please test the latest binary firmware? https://github.com/LaosLaser/Firmware/blob/master/laoslaser-22-05-2014.bin

TheGuv commented 10 years ago

I'll try and test it tonight and report back. Thanks!

thinkl33t commented 10 years ago

https://github.com/TheGuv/Firmware/commit/60d4ad7620edb370dbb1191056d33fdb2094cecb#diff-cd58c9fe2e2dcf2b930448d127a62069R194

I think these two lines are missing from the changes Jaap has made, and I cant see anything that actually turns on the exhaust, though I may be missing it?

jrv commented 10 years ago

You're right, there's two important lines missing from the patch! I've added them now and updated the binary too. Hope I didn't miss anything else!

thinkl33t commented 10 years ago

Could the Laser Enable pin be used for running a cooling pump using the same code (with its own timeout number)? I've checked the source and it doesn't seem to be used for anything (laser is controlled through "Laser On" and "Laser PWM")

jrv commented 10 years ago

That could be a new patch, it's not relevant for this one. I'm more in favor of controlling watercooling via I2C, because you would also need flow and temperature feedback to do it right. Any feedback on if this patch works now?

jrv commented 10 years ago

Suppose it works now...