[enhancement] Composer scripts usage

Lapinskas / roadrunner-ubiquity

RoadRunner and Ubiquity integration

MIT License

9 stars 3 forks source link

[enhancement] Composer scripts usage #12

Open jcheron opened 4 years ago

jcheron commented 4 years ago

Why not use the composer scripts, to facilitate the installation :

The following manipulations:

vendor/bin/rr get
cp vendor/lapinskas/roadrunner-ubiquity/sample/.rr.yml .rr.yml
cp vendor/lapinskas/roadrunner-ubiquity/sample/worker.php worker.php

could be done by a script running on the post-install-cmd event

Lapinskas commented 4 years ago

We have added script for the installation: vendor/bin/rr-ub-install that facilitates manual manirulations

Unfortunately, composer has limitations on running scripts from dependent packages (I think due to security reasons), so we can't trigger scrips automatically

Note: Only scripts defined in the root package's composer.json are executed. If a dependency of the root package specifies its own scripts, Composer does not execute those additional scripts. https://getcomposer.org/doc/articles/scripts.md

jcheron commented 4 years ago

Actually, I hadn't noticed that. If you wish, you can integrate RoadRunner with the devtools.

2 additions are to be made in the Ubiquity file:

For the addition to the servers list: https://github.com/phpMv/ubiquity-devtools/blob/764ee7b4525d1db2df48a4aea54f10a9b4762664/src/Ubiquity#L53
For the launch https://github.com/phpMv/ubiquity-devtools/blob/764ee7b4525d1db2df48a4aea54f10a9b4762664/src/Ubiquity#L766

This will make it possible to do: Ubiquity serve -t=roadrunner