search

LaraBug / LaraBug

Laravel error reporting tool
https://www.larabug.com
MIT License
267 stars 58 forks source link

Add support for installation on a lumen project #50

Closed mateussantana closed 3 years ago

mateussantana commented 3 years ago

Two little adaptations on code is necessary to turn it possible an installation on lumen micro framework:

  1. The way the routes are registred;
  2. A check of guards on getUser().

The documentation was also updated.

mateussantana commented 3 years ago

Rreopening...

Cannonb4ll commented 3 years ago

Is this ready for a review?

mateussantana commented 3 years ago

I think it is. Just tested on a fresh lumen and laravel installation. Both on latest versions. If more people would test, it's better.

Cannonb4ll commented 3 years ago

I've just tried this but I keep getting this error:

RuntimeException
HTTP 500 Internal Server Error
A facade root has not been set.

Have I missed something?

mateussantana commented 3 years ago

Did you uncomment $app->withFacades(); in bootstrap/app.php? This information was added on last commit 684f0f4df70672dbf303d056cfcfc3d5b2f93264

Glennmen commented 3 years ago

@Cannonb4ll I think you need to change something in project settings 🤔 The workflow is not being triggered.

Cannonb4ll commented 3 years ago

@Glennmen Not sure what happened with the workflow, I needed to approve it? What do you think of the results?

Glennmen commented 3 years ago

It failed with Laravel 6.0.0 on PHP 7.4 but not sure why 🤔 Maybe a bug in that version?

Cannonb4ll commented 3 years ago

I think so, because when I test manually it's fine. I blame workflows 😅