Laragear / WebAuthn

Authenticate users with Passkeys: fingerprints, patterns and biometric data.
MIT License
308 stars 37 forks source link

[1.1.3] FIX: Query error when disabling all credentials #23

Closed Bubka closed 1 year ago

Bubka commented 1 year ago

Description

This fix removes references to an unknown column that throw an exception during credentials disabling.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

codecov[bot] commented 1 year ago

Codecov Report

Base: 82.34% // Head: 82.34% // No change to project coverage :thumbsup:

Coverage data is based on head (ef3ad38) compared to base (af04066). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 1.x #23 +/- ## ========================================= Coverage 82.34% 82.34% Complexity 367 367 ========================================= Files 61 61 Lines 929 929 ========================================= Hits 765 765 Misses 164 164 ``` | [Impacted Files](https://codecov.io/gh/Laragear/WebAuthn/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Laragear) | Coverage Δ | | |---|---|---| | [src/Models/WebAuthnCredential.php](https://codecov.io/gh/Laragear/WebAuthn/pull/23/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Laragear#diff-c3JjL01vZGVscy9XZWJBdXRobkNyZWRlbnRpYWwucGhw) | `100.00% <ø> (ø)` | | | [src/WebAuthnAuthentication.php](https://codecov.io/gh/Laragear/WebAuthn/pull/23/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Laragear#diff-c3JjL1dlYkF1dGhuQXV0aGVudGljYXRpb24ucGhw) | `25.92% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Laragear). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Laragear)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

DarkGhostHunter commented 1 year ago

Thanks. I'll add a test for that so it doesn't break in the future.